You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/08 12:04:29 UTC

[GitHub] [spark] pengbo opened a new pull request #24317: [Spark 27406][SQL]UnsafeArrayData serialization breaks when two machines have different Oops size

pengbo opened a new pull request #24317: [Spark 27406][SQL]UnsafeArrayData serialization breaks when two machines have different Oops size
URL: https://github.com/apache/spark/pull/24317
 
 
   ## What changes were proposed in this pull request?
   ApproxCountDistinctForIntervals holds the UnsafeArrayData data to initialize endpoints. When the UnsafeArrayData is serialized with Java serialization, the BYTE_ARRAY_OFFSET in memory can change if two machines have different pointer width (Oops in JVM).
   
   This PR fixes this issue by using the same way in https://github.com/apache/spark/pull/9030
   
   ## How was this patch tested?
   Manual test has been done in our tpcds environment and regarding unit test case has been added as well
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org