You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/10/24 02:07:49 UTC

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #429: [IOTDB-205]Support storage-group-level data ttl

fanhualta commented on a change in pull request #429: [IOTDB-205]Support storage-group-level data ttl
URL: https://github.com/apache/incubator-iotdb/pull/429#discussion_r338352105
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -309,7 +310,7 @@ public TSFetchMetadataResp fetchMetadata(TSFetchMetadataReq req) {
           status = new TSStatus(getStatus(TSStatusCode.SUCCESS_STATUS));
           break;
         case "SHOW_STORAGE_GROUP":
-          Set<String> storageGroups = getAllStorageGroups();
+          Set<String> storageGroups = new HashSet<>(getAllStorageGroups());
 
 Review comment:
   I think it's unnecessary to wrap `getAllStorageGroups()` with a `new HashSet<>`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services