You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/05 22:46:48 UTC
[GitHub] [activemq-nms-amqp] lrushl opened a new pull request #55:
AMQNET-639 Add SourceLink support
lrushl opened a new pull request #55: AMQNET-639 Add SourceLink support
URL: https://github.com/apache/activemq-nms-amqp/pull/55
I'd like to add SourceLink support to this library in order to simplify debugging from referencing projects.
It would be great to first merge [AMQNET-638 Add SourceLink support](https://github.com/apache/activemq-nms-api/pull/13) and then update [Apache.NMS](https://github.com/apache/activemq-nms-amqp/blob/f1b1f67e1d15b714d7a7c2c827ceeac9978b7a33/src/NMS.AMQP/Apache-NMS-AMQP.csproj#L84) package reference to v.1.8.1
Please take a look into the small demo of SourceLink in action
For more details on how to enable debugging with SourceLink please check the following guides:
- [How to Configure Visual Studio to Use SourceLink to Step into NuGet Package Source](http://www.aaronstannard.com/visual-studio-sourcelink-setup/)
- [Debugging into NuGet packages with SourceLink in Visual Studio for Mac](https://docs.microsoft.com/en-us/visualstudio/mac/source-link?view=vsmac-2019)
For more details on SoureLink, please navigate the following links:
- [dotnet/sourcelink](https://github.com/dotnet/sourcelink)
- [SourceLink file specification](https://github.com/dotnet/designs/blob/master/accepted/2020/diagnostics/source-link.md#source-link-file-specification)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelpearce-gain commented on issue #55:
AMQNET-639 Add SourceLink support
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on issue #55: AMQNET-639 Add SourceLink support
URL: https://github.com/apache/activemq-nms-amqp/pull/55#issuecomment-611432894
+1 from me also, lets merge this! @lrushl thanks, also re your mail to dev, did you get my reply? one main thing would be that we make sure examples available in artemis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in
pull request #55: AMQNET-639 Add SourceLink support
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #55: AMQNET-639 Add SourceLink support
URL: https://github.com/apache/activemq-nms-amqp/pull/55#discussion_r405842756
##########
File path: package.ps1
##########
@@ -14,7 +14,7 @@
# limitations under the License.
$pkgname = "Apache.NMS.AMQP"
-$pkgver = "1.8.0"
+$pkgver = "1.8.2"
Review comment:
Seems this isnt used rather than update it, maybe we remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in
pull request #55: AMQNET-639 Add SourceLink support
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #55: AMQNET-639 Add SourceLink support
URL: https://github.com/apache/activemq-nms-amqp/pull/55#discussion_r405842756
##########
File path: package.ps1
##########
@@ -14,7 +14,7 @@
# limitations under the License.
$pkgname = "Apache.NMS.AMQP"
-$pkgver = "1.8.0"
+$pkgver = "1.8.2"
Review comment:
Seems this isnt used rather than update it, maybe we remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] Havret removed a comment on issue #55:
AMQNET-639 Add SourceLink support
Posted by GitBox <gi...@apache.org>.
Havret removed a comment on issue #55: AMQNET-639 Add SourceLink support
URL: https://github.com/apache/activemq-nms-amqp/pull/55#issuecomment-609565018
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] Havret commented on issue #55: AMQNET-639 Add
SourceLink support
Posted by GitBox <gi...@apache.org>.
Havret commented on issue #55: AMQNET-639 Add SourceLink support
URL: https://github.com/apache/activemq-nms-amqp/pull/55#issuecomment-609565018
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-nms-amqp] Havret merged pull request #55: AMQNET-639 Add
SourceLink support
Posted by GitBox <gi...@apache.org>.
Havret merged pull request #55: AMQNET-639 Add SourceLink support
URL: https://github.com/apache/activemq-nms-amqp/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services