You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by hmcl <gi...@git.apache.org> on 2016/11/15 05:55:28 UTC

[GitHub] storm issue #1687: STORM-1694: Kafka Spout Trident Implementation Using New ...

Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/1687
  
    @harshach I have changed the titles of the PRs, however what is really important are the git commit messages, and those were correct. Once the patch is merged, no one will ever look at the PR titles again, only at the git commit logs.
    
    I don't think we should close this PR in order to keep the history of the review comments. Also, the title of this PR reflects this patch. The title of the other PR reflects the other patch that is on top of this patch.
    
    There is no extra work in merging the two PRs and the git commit history is the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---