You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/04 19:23:49 UTC
[GitHub] [airflow] kaxil opened a new pull request #15191: Bugfix: Task docs are not shown in the Task Instance Detail View
kaxil opened a new pull request #15191:
URL: https://github.com/apache/airflow/pull/15191
closes https://github.com/apache/airflow/issues/15178
closes https://github.com/apache/airflow/issues/13761
This feature was added in 2015 in https://github.com/apache/airflow/pull/74 and it was expected to set `doc_md` (or `doc_rst` and other `doc_*`) via `task.doc_md` instead of passing via arg. However, this did not work with DAG Serialization as we only allowed a selected args to be stored in Serialized version of DAG.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15191: Bugfix: Task docs are not shown in the Task Instance Detail View
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15191:
URL: https://github.com/apache/airflow/pull/15191#discussion_r606852448
##########
File path: airflow/www/views.py
##########
@@ -1247,7 +1247,7 @@ def task(self):
# Color coding the special attributes that are code
special_attrs_rendered = {}
for attr_name in wwwutils.get_attr_renderer():
- if hasattr(task, attr_name):
+ if getattr(task, attr_name, None) is not None:
Review comment:
This is to not show attributes that are `None` -- that pollutes the TaskInstance screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15191: Bugfix: Task docs are not shown in the Task Instance Detail View
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15191:
URL: https://github.com/apache/airflow/pull/15191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15191: Bugfix: Task docs are not shown in the Task Instance Detail View
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15191:
URL: https://github.com/apache/airflow/pull/15191#discussion_r606852663
##########
File path: airflow/www/utils.py
##########
@@ -338,7 +338,7 @@ def json_render(obj, lexer):
return out
-def wrapped_markdown(s, css_class=None):
+def wrapped_markdown(s, css_class='rich_doc'):
Review comment:
It was always `rich_doc` in 1.10.x , example:
https://github.com/apache/airflow/blob/1.10.15/airflow/www_rbac/utils.py#L316-L322
However, we pass `None` at few places, so just making it the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15191: Bugfix: Task docs are not shown in the Task Instance Detail View
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15191:
URL: https://github.com/apache/airflow/pull/15191#issuecomment-813113908
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org