[jira] [Commented] (ISIS-815) Internationalization of Wicket UI elements (edit, ok, cancel, logout, about)

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100619#comment-14100619 ] 

Martin Grigorov commented on ISIS-815:
--------------------------------------

Hi again,

The problem is clear.
By setting your custom ResourceSettings impl in #internalInit() you let Wicket to configure some defaults for it at
1) https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Application.java#L672
2) https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java#L624

If you set a completely new IResourceSettings impl in #init() then all these defaults are lost.

The (missing )call that breaks your use case is: https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Application.java#L689
Without ClassPathResourceFinder Wicket won't be able to locate any kind of resource sitting next to MyScope.class.

You can leave your code as is.
Or rework it as at: https://gist.github.com/martin-g/2f04df5ad4a9b2eb78c8

> Internationalization of Wicket UI elements (edit, ok, cancel, logout, about)
> ----------------------------------------------------------------------------
>
>                 Key: ISIS-815
>                 URL: https://issues.apache.org/jira/browse/ISIS-815
>             Project: Isis
>          Issue Type: Improvement
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.5.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: viewer-wicket-1.6.0
>
>
> Using Wicket's built-in i18n capabilities, but tweaked so that application-scoped properties override page-scope properties (rather than other way around)



--
This message was sent by Atlassian JIRA
(v6.2#6252)