You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:16:04 UTC

[GitHub] [hbase-thirdparty] joshelser commented on pull request #22: HBASE-19256 [hbase-thirdparty] shade jetty

joshelser commented on pull request #22:
URL: https://github.com/apache/hbase-thirdparty/pull/22#issuecomment-664726639


   Glancing at the jars, I see some ServiceLoader entries in both the jetty and jersey jars. I _think_ this would break, if we happen to use it, given the entry in the jar and the values in the file are both pointing at unshaded locations.
   
   The maven-shade-plugin does have a transformer for these https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer. It might be just as easy as enabling that along with the others you already have.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org