You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/08/13 07:06:47 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #2105: [CALCITE-4159] Simplify always-true expressions (such as LIKE '%') to TRUE

julianhyde commented on a change in pull request #2105:
URL: https://github.com/apache/calcite/pull/2105#discussion_r469740562



##########
File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##########
@@ -3763,7 +3765,7 @@ LogicalProject(DEPTNO=[$7])
     </TestCase>
     <TestCase name="testReduceConstExpr">
         <Resource name="sql">
-            <![CDATA[select sum(case when 'y' = 'n' then ename else 1 end) from emp]]>
+            <![CDATA[select sum(case when 'y' = 'n' then ename else 0.1 end) from emp]]>
         </Resource>

Review comment:
       Yes, the 'sql' originates in `SqlToRelConverterTest.java`. I just updated `SqlToRelConverterTest.xml` to match what was already in the java.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org