You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/26 05:09:42 UTC

[GitHub] [incubator-inlong] healchow commented on a change in pull request #3374: [INLONG-3369] Add streamsource in group/list Api

healchow commented on a change in pull request #3374:
URL: https://github.com/apache/incubator-inlong/pull/3374#discussion_r835719214



##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/InlongGroupServiceImpl.java
##########
@@ -206,6 +219,24 @@ public InlongGroupInfo get(String groupId) {
         Page<InlongGroupEntity> entityPage = (Page<InlongGroupEntity>) groupMapper.selectByCondition(request);
         List<InlongGroupListResponse> groupList = CommonBeanUtils.copyListProperties(entityPage,
                 InlongGroupListResponse::new);
+        if (request.isListSources() && CollectionUtils.isNotEmpty(groupList)) {

Review comment:
       There may be a lot of streams and sources under these groups, and the result set of the query may be very large.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org