You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by johnament <gi...@git.apache.org> on 2016/08/02 23:50:03 UTC
[GitHub] cxf pull request #149: [CXF-6987] Also consider the classees defined on an a...
GitHub user johnament opened a pull request:
https://github.com/apache/cxf/pull/149
[CXF-6987] Also consider the classees defined on an application when \u2026
\u2026singletons are populated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnament/cxf CXF-6987
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit ac209a93df3403424ea2300bd2252d55b65b0836
Author: John D. Ament <jo...@apache.org>
Date: 2016-08-02T23:49:29Z
[CXF-6987] Also consider the classees defined on an application when singletons are populated.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #149: [CXF-6987] Also consider the classees defined on an a...
Posted by reta <gi...@git.apache.org>.
Github user reta commented on a diff in the pull request:
https://github.com/apache/cxf/pull/149#discussion_r73263806
--- Diff: integration/cdi/src/main/java/org/apache/cxf/cdi/JAXRSCdiResourceExtension.java ---
@@ -179,7 +185,13 @@ private JAXRSServerFactoryBean createFactoryInstance(final Application applicati
classified.get(Path.class).add(singleton);
}
}
-
+
+ // now loop through the classes
+ Set<Class<?>> classes = application.getClasses();
+ if (!classes.isEmpty()) {
+ classified.get(Path.class).addAll(loadServices(beanManager, classes));
+ classified.get(Provider.class).addAll(loadProviders(beanManager, classes));
--- End diff --
Would you mind to add Feature.class as well? Yeah, it is CXF, not JAX-RS feature, but it won't hurt to have the same behavior as with singletons. Minor comment though, leaving choice to you. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classees defined on an applicat...
Posted by reta <gi...@git.apache.org>.
Github user reta commented on the issue:
https://github.com/apache/cxf/pull/149
LGTM, thank you. Good one, covers more JAX-RS/CDI scenarios.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #149: [CXF-6987] Also consider the classes defined on an ap...
Posted by johnament <gi...@git.apache.org>.
Github user johnament closed the pull request at:
https://github.com/apache/cxf/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classees defined on an applicat...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/cxf/pull/149
Restarted jenkins, test failure seems unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classes defined on an applicati...
Posted by reta <gi...@git.apache.org>.
Github user reta commented on the issue:
https://github.com/apache/cxf/pull/149
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classes defined on an applicati...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/cxf/pull/149
Oh, you merged it! Heh, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classees defined on an applicat...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/cxf/pull/149
Apologies, as some formatting changes went in as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #149: [CXF-6987] Also consider the classees defined on an a...
Posted by reta <gi...@git.apache.org>.
Github user reta commented on a diff in the pull request:
https://github.com/apache/cxf/pull/149#discussion_r73266477
--- Diff: integration/cdi/src/main/java/org/apache/cxf/cdi/JAXRSCdiResourceExtension.java ---
@@ -179,7 +185,13 @@ private JAXRSServerFactoryBean createFactoryInstance(final Application applicati
classified.get(Path.class).add(singleton);
}
}
-
+
+ // now loop through the classes
+ Set<Class<?>> classes = application.getClasses();
+ if (!classes.isEmpty()) {
+ classified.get(Path.class).addAll(loadServices(beanManager, classes));
+ classified.get(Provider.class).addAll(loadProviders(beanManager, classes));
--- End diff --
:+1: Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #149: [CXF-6987] Also consider the classees defined on an a...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/cxf/pull/149#discussion_r73264429
--- Diff: integration/cdi/src/main/java/org/apache/cxf/cdi/JAXRSCdiResourceExtension.java ---
@@ -179,7 +185,13 @@ private JAXRSServerFactoryBean createFactoryInstance(final Application applicati
classified.get(Path.class).add(singleton);
}
}
-
+
+ // now loop through the classes
+ Set<Class<?>> classes = application.getClasses();
+ if (!classes.isEmpty()) {
+ classified.get(Path.class).addAll(loadServices(beanManager, classes));
+ classified.get(Provider.class).addAll(loadProviders(beanManager, classes));
--- End diff --
Shoot, thanks. I actually wrote the code for features, but then removed it in my formatting clean up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #149: [CXF-6987] Also consider the classees defined on an a...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/cxf/pull/149#discussion_r73265627
--- Diff: integration/cdi/src/main/java/org/apache/cxf/cdi/JAXRSCdiResourceExtension.java ---
@@ -179,7 +185,13 @@ private JAXRSServerFactoryBean createFactoryInstance(final Application applicati
classified.get(Path.class).add(singleton);
}
}
-
+
+ // now loop through the classes
+ Set<Class<?>> classes = application.getClasses();
+ if (!classes.isEmpty()) {
+ classified.get(Path.class).addAll(loadServices(beanManager, classes));
+ classified.get(Provider.class).addAll(loadProviders(beanManager, classes));
--- End diff --
Fixed, thanks @reta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classes defined on an applicati...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/cxf/pull/149
I'm going to close and create a new PR to see if that will force jenkins to rebuild. Would it be OK if I modified the job to have a longer history?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classes defined on an applicati...
Posted by sberyozkin <gi...@git.apache.org>.
Github user sberyozkin commented on the issue:
https://github.com/apache/cxf/pull/149
Hi, re "Would it be OK if I modified the job to have a longer history?" - sounds reasonable, Dan, what do you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #149: [CXF-6987] Also consider the classes defined on an applicati...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/cxf/pull/149
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---