[GitHub] [geode-native] echobravopapa commented on a change in pull request #783: Revert fix for GEODE-8231

[GitBox <gi...@apache.org>]

echobravopapa commented on a change in pull request #783:
URL: https://github.com/apache/geode-native/pull/783#discussion_r612809674



##########
File path: cppcache/src/ClientMetadata.cpp
##########
@@ -153,15 +143,30 @@ void ClientMetadata::getServerLocation(
     } else {
       version = serverLocation->getVersion();
     }
-    LOGFINER("returning random & m_bucketServerLocationsList size is: %zu",
-             m_bucketServerLocationsList.size());
     RandGen randgen;
     serverLocation = m_bucketServerLocationsList[bucketId].at(randgen(
         static_cast<int>(m_bucketServerLocationsList[bucketId].size())));
   }
   // return m_bucketServerLocationsList[bucketId].at(0);
 }
 
+/*

Review comment:
       here too

##########
File path: cppcache/src/ClientMetadata.cpp
##########
@@ -114,24 +114,14 @@ const std::string& ClientMetadata::getColocatedWith() {
   return m_colocatedWith;
 }
 
-void ClientMetadata::removeBucketServerLocation(
-    const std::shared_ptr<BucketServerLocation>& serverLocation) {
-  for (auto&& locations : m_bucketServerLocationsList) {
-    for (unsigned int i = 0; i < locations.size(); i++) {
-      if (locations[i]->getEpString() == (serverLocation->getEpString())) {
-        locations.erase(locations.begin() + i);
-        break;
-      }
-    }
-  }
-}
-
 void ClientMetadata::getServerLocation(
     int bucketId, bool tryPrimary,
     std::shared_ptr<BucketServerLocation>& serverLocation, int8_t& version) {
+  // ReadGuard guard (m_readWriteLock);

Review comment:
       can we lose this dead code while we're in here... thx




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org