You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/05 12:46:16 UTC
[GitHub] [lucene-solr] noblepaul opened a new pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)
noblepaul opened a new pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177
WIP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul edited a comment on pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)
Posted by GitBox <gi...@apache.org>.
noblepaul edited a comment on pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-755019793
> Please note that there are still a lot of outstanding comments on the 8x version of this PR, I worry that you are going to end up doing double work trying to maintain two patch sets for a time.
Unfortunately, our 8x and trunk have diverged a lot and we cannot apply any patch across branches. We have to build them in parallel. I would address them and port them here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)
Posted by GitBox <gi...@apache.org>.
noblepaul commented on pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-755019793
> Please note that there are still a lot of outstanding comments on the 8x version of this PR, I worry that you are going to end up doing double work trying to maintain two patch sets for a time.
Unfortunately, our 8x and trunk have diverged a lot and we cannot apply any patch across branches. We have to build them in parallel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-754810146
Please note that there are still a lot of outstanding comments on the 8x version of this PR, I worry that you are going to end up doing double work trying to maintain two patch sets for a time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul edited a comment on pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)
Posted by GitBox <gi...@apache.org>.
noblepaul edited a comment on pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-755019793
> Please note that there are still a lot of outstanding comments on the 8x version of this PR, I worry that you are going to end up doing double work trying to maintain two patch sets for a time.
Unfortunately, our 8x and trunk have diverged a lot and we cannot apply any patch across branches. We have to build them in parallel. I would address the feedback and port them here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177#discussion_r551961005
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##########
@@ -1219,17 +1225,28 @@ public void process(WatchedEvent event) {
event, coll, liveNodes.size());
}
- refreshAndWatch();
+ refreshAndWatch(event.getType());
}
+ public void refreshAndWatch() {
+ refreshAndWatch(null);
Review comment:
*THREAD_SAFETY_VIOLATION:* Unprotected write. Non-private method `ZkStateReader$StateWatcher.refreshAndWatch()` indirectly writes to field `noggit.JSONParser.devNull.buf` outside of synchronization.
Reporting because another access to the same memory occurs on a background thread, although this access may not.
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##########
@@ -1219,17 +1225,28 @@ public void process(WatchedEvent event) {
event, coll, liveNodes.size());
}
- refreshAndWatch();
+ refreshAndWatch(event.getType());
}
+ public void refreshAndWatch() {
+ refreshAndWatch(null);
+ }
/**
* Refresh collection state from ZK and leave a watch for future changes.
* As a side effect, updates {@link #clusterState} and {@link #watchedCollectionStates}
* with the results of the refresh.
*/
- public void refreshAndWatch() {
+ public void refreshAndWatch(EventType eventType) {
try {
+ if (eventType == null || eventType == EventType.NodeChildrenChanged) {
+ refreshAndWatchChildren();
Review comment:
*THREAD_SAFETY_VIOLATION:* Unprotected write. Non-private method `ZkStateReader$StateWatcher.refreshAndWatch(...)` indirectly writes to field `noggit.JSONParser.devNull.buf` outside of synchronization.
Reporting because this access may occur on a background thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul merged pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)
Posted by GitBox <gi...@apache.org>.
noblepaul merged pull request #2177:
URL: https://github.com/apache/lucene-solr/pull/2177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org