[GitHub] [tvm] areusch commented on a diff in pull request #11509: Constant name prefix added

[GitBox <gi...@apache.org>]

areusch commented on code in PR #11509:
URL: https://github.com/apache/tvm/pull/11509#discussion_r893852126


##########
src/relay/backend/te_compiler_cache.cc:
##########
@@ -193,7 +193,7 @@ class LowerToTECompute : public backend::MemoizedExprTranslator<Array<te::Tensor
     } else {
       const auto* ttype = op->checked_type().as<TensorTypeNode>();
       std::stringstream ss;
-      ss << "constant_" << const_index++;
+      ss << "cc_constant_" << const_index++;

Review Comment:
   i discussed this with @Mousius a bit. his view is that we should adopt an intermediate solution to this problem to bugfix, and then take up the architectural issue later.
   
   How about the following compromise: 
   - here we fix the bug so we can release without it by using `candidate_name_` as part of the prefix so it's not just randomly `cc_constant_N`.
   - I wrote up the broader architectural issue in a [Discuss pre-RFC](https://discuss.tvm.apache.org/t/pre-rfc-name-mangling-in-irmodules/12944) and would love comments there.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org