You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/01 18:30:57 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4772: Simplify the
constant calculation in CombinePlanNode
codecov-io commented on issue #4772: Simplify the constant calculation in CombinePlanNode
URL: https://github.com/apache/incubator-pinot/pull/4772#issuecomment-548901223
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4772?src=pr&el=h1) Report
> Merging [#4772](https://codecov.io/gh/apache/incubator-pinot/pull/4772?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/4afabcab0dffe7fa818260a3c0d7cda04b6324be?src=pr&el=desc) will **increase** coverage by `12.13%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4772/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4772?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4772 +/- ##
=============================================
+ Coverage 37.86% 49.99% +12.13%
- Complexity 0 4 +4
=============================================
Files 1209 1209
Lines 64973 64973
Branches 9467 9465 -2
=============================================
+ Hits 24601 32484 +7883
+ Misses 38141 29924 -8217
- Partials 2231 2565 +334
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4772?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/pinot/core/plan/CombinePlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0NvbWJpbmVQbGFuTm9kZS5qYXZh) | `77.04% <100%> (+6.55%)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...pache/pinot/core/realtime/stream/MessageBatch.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vTWVzc2FnZUJhdGNoLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...che/pinot/hadoop/io/CombineAvroKeyInputFormat.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtaGFkb29wL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9oYWRvb3AvaW8vQ29tYmluZUF2cm9LZXlJbnB1dEZvcm1hdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | |
| [...re/data/manager/config/TableDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvY29uZmlnL1RhYmxlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | |
| [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | |
| [...ot/hadoop/job/partitioners/GenericPartitioner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtaGFkb29wL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9oYWRvb3Avam9iL3BhcnRpdGlvbmVycy9HZW5lcmljUGFydGl0aW9uZXIuamF2YQ==) | `0% <0%> (-93.34%)` | `0% <0%> (ø)` | |
| [...a/org/apache/pinot/common/metrics/ServerTimer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9TZXJ2ZXJUaW1lci5qYXZh) | `0% <0%> (-88.89%)` | `0% <0%> (ø)` | |
| [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | |
| ... and [732 more](https://codecov.io/gh/apache/incubator-pinot/pull/4772/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4772?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4772?src=pr&el=footer). Last update [4afabca...5d70f60](https://codecov.io/gh/apache/incubator-pinot/pull/4772?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org