You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2017/12/01 00:25:45 UTC

[GitHub] spark pull request #19631: [SPARK-22372][core, yarn] Make cluster submission...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19631#discussion_r154240414
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -542,7 +496,54 @@ private[spark] class SecurityManager(
        * Gets the secret key.
        * @return the secret key as a String if authentication is enabled, otherwise returns null
        */
    -  def getSecretKey(): String = secretKey
    +  def getSecretKey(): String = {
    +    if (isAuthenticationEnabled) {
    +      Option(sparkConf.getenv(ENV_AUTH_SECRET))
    --- End diff --
    
    I changed things and now they work pretty much as before. It would be good to separate secret generation from distribution, but I'd rather do that separately.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org