You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/24 17:03:15 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #1369: [Python] add python 3.7 and 3.8 to CI

rdblue commented on a change in pull request #1369:
URL: https://github.com/apache/iceberg/pull/1369#discussion_r475762670



##########
File path: .travis.yml
##########
@@ -45,10 +45,28 @@ matrix:
         - $HOME/.gradle/wrapper/
 
   - language: python
-    python: 3.6
+    python:
+      - 3.6
     before_script:
       - cd python
       - pip install -e .[dev]
+      - pip install -U tox-travis
+    script: tox
+  - language: python
+    python:
+      - 3.7
+    before_script:
+      - cd python
+      - pip install -e .[dev]
+      - pip install -U tox-travis
+    script: tox
+  - language: python
+    python:
+      - 3.8

Review comment:
       It looks fine with all 3 separate, but the 3.8 config lists both 3.6 and 3.7 as well. Should those be removed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org