You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/11 04:21:55 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #35813: Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
xinrong-databricks opened a new pull request #35813:
URL: https://github.com/apache/spark/pull/35813
### What changes were proposed in this pull request?
Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
### Why are the changes needed?
To reach parity with pandas.
### Does this PR introduce _any_ user-facing change?
Yes. `skipna` is supported as below:
```py
>>> ps.Series([1, 2, 3, np.nan]).all(skipna=False)
True
>>> ps.Series([True, True, None]).all(skipna=False)
False
```
### How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35813: [SPARK-38518][PYTHON] Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35813:
URL: https://github.com/apache/spark/pull/35813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #35813: [SPARK-38518][PYTHON] Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #35813:
URL: https://github.com/apache/spark/pull/35813#issuecomment-1064974087
CC @ueshin @HyukjinKwon @itholic Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #35813: [SPARK-38518][PYTHON] Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #35813:
URL: https://github.com/apache/spark/pull/35813#issuecomment-1064973209
Failed at Run Documentation Build with
```
Extension error:
Could not import extension nbsphinx (exception: No module named 'ipython_genutils')
make: *** [Makefile:35: html] Error 2
------------------------------------------------
Jekyll 4.2.1 Please append `--trace` to the `build` command
for any additional information or backtrace.
------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35813: [SPARK-38518][PYTHON] Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35813:
URL: https://github.com/apache/spark/pull/35813#issuecomment-1064990237
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #35813: [SPARK-38518][PYTHON] Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #35813:
URL: https://github.com/apache/spark/pull/35813#issuecomment-1066250722
Thanks @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35813: [SPARK-38518][PYTHON] Implement `skipna` of `Series.all/Index.all` to exclude NA/null values
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35813:
URL: https://github.com/apache/spark/pull/35813#issuecomment-1064989673
That's fixed in https://github.com/apache/spark/commit/54abb85aa303b9ccca9a127b45f53e2acc5de438. Rebasing and syncing the to master branch should fix the documentation build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org