You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Scott Lamb (JIRA)" <ji...@codehaus.org> on 2005/06/17 20:16:58 UTC

[jira] Created: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Show errors on maven.checkstyle.fail.on.violation
-------------------------------------------------

         Key: MPCHECKSTYLE-34
         URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
     Project: maven-checkstyle-plugin
        Type: Improvement
    Versions: 2.5    
    Reporter: Scott Lamb
    Priority: Minor


I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:

    BUILD FAILED
    File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
    Element... ant:checkstyle
    Line...... 144
    Column.... 63
    Got 15 errors.

To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:

- They'd show up in the Cruise Control emails
- I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
- It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Scott Lamb (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=comments#action_41517 ] 

Scott Lamb commented on MPCHECKSTYLE-34:
----------------------------------------

Are you suggesting two separate invocations of maven? As in:

    $ maven -D maven.checkstyle.fail.on.violation=false site
    $ maven

or is there a way to get maven to run the same target twice from the same invocation, with different options the second time?

I'd like this to be as simple as possible to use.

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Arnaud HERITIER (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=comments#action_41526 ] 

Arnaud HERITIER commented on MPCHECKSTYLE-34:
---------------------------------------------

did you try theses settings ?
maven.checkstyle.fail.on.violation = true
maven.checkstyle.usefile = false

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=comments#action_41516 ] 

Carlos Sanchez commented on MPCHECKSTYLE-34:
--------------------------------------------

You should run first "site" so you get the html reports, and then run the check to fail on violation

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Scott Lamb (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=comments#action_41518 ] 

Scott Lamb commented on MPCHECKSTYLE-34:
----------------------------------------

Never mind; I see your workaround at MPCHECKSTYLE-28. I'll give that a shot.

I'd still like this to put the precise errors on stdout, though.

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Arnaud HERITIER (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=all ]
     
Arnaud HERITIER closed MPCHECKSTYLE-34:
---------------------------------------

     Resolution: Won't Fix
    Fix Version: 3.0

invalid

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor
>      Fix For: 3.0

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Scott Lamb (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=comments#action_41547 ] 

Scott Lamb commented on MPCHECKSTYLE-34:
----------------------------------------

Oh, wow. I can't believe I missed maven.checkstyle.usefile. It works fine. Thanks.

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Arnaud HERITIER (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=comments#action_41548 ] 

Arnaud HERITIER commented on MPCHECKSTYLE-34:
---------------------------------------------

can we close this issue ?

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MPCHECKSTYLE-34) Show errors on maven.checkstyle.fail.on.violation

Posted by "Scott Lamb (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPCHECKSTYLE-34?page=comments#action_41549 ] 

Scott Lamb commented on MPCHECKSTYLE-34:
----------------------------------------

Yeah. I don't see an "invalid" resolution. Is it "won't fix"?

> Show errors on maven.checkstyle.fail.on.violation
> -------------------------------------------------
>
>          Key: MPCHECKSTYLE-34
>          URL: http://jira.codehaus.org/browse/MPCHECKSTYLE-34
>      Project: maven-checkstyle-plugin
>         Type: Improvement
>     Versions: 2.5
>     Reporter: Scott Lamb
>     Priority: Minor

>
>
> I turned on maven.checkstyle.fail.on.violation, so our builds fail on serious enough errors. It works, but the output is not terribly enlightening:
>     BUILD FAILED
>     File...... /Users/slamb/.maven/cache/maven-checkstyle-plugin-2.5/plugin.jelly
>     Element... ant:checkstyle
>     Line...... 144
>     Column.... 63
>     Got 15 errors.
> To actually find what the error was, I have to dig into build/checkstyle-raw-report.txt. It'd be much more helpful if it actually send the offending errors to stdout. This would be better because:
> - They'd show up in the Cruise Control emails
> - I wouldn't have to do a "egrep -v ': (warning|info):' build/checkstyle-raw-report.txt" to find the errors...checkstyle doesn't even write "error" on error lines.
> - It'd integrate better with editors that grep the build output to take you to the violation automatically.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org