You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/02/28 20:24:00 UTC
[jira] [Commented] (LUCENE-9114) Add FunctionValues.cost
[ https://issues.apache.org/jira/browse/LUCENE-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047928#comment-17047928 ]
David Smiley commented on LUCENE-9114:
--------------------------------------
If this is too time-consuming, we could reduce the scope to merely make the cost settable by a query parser (this issue not touching any query parser, however). That's the minimum I need to unblock using the costs on the Solr side (it's QParsers), which I want to do after this.
> Add FunctionValues.cost
> -----------------------
>
> Key: LUCENE-9114
> URL: https://issues.apache.org/jira/browse/LUCENE-9114
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/query
> Reporter: David Smiley
> Priority: Major
>
> The FunctionRangeQuery uses FunctionValues.getRangeScorer which returns a subclass of ValueSourceScorer. VSC's TwoPhaseIterator has a matchCost impl that returns a constant 100. This is pretty terrible; the cost should vary based on the complexity of the ValueSource provided to FRQ. ValueSource's are typically nested a number of levels, so they should aggregate.
> BTW there is a parallel concern for FunctionMatchQuery which works with DoubleValuesSource which doesn't have a cost either, and unsurprisingly there is a TPI with matchCost 100 there.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org