[jira] [Commented] (TEZ-2179) Timeline related entries missing cause exaggerated warning

["Chang Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349451#comment-14349451 ] 

Chang Li commented on TEZ-2179:
-------------------------------

I think the easy fix may be to change the way to log in handleEvents within ATSHistoryLoggingService. 
Currently the code will handle error codes by 
{code}
if (err.getErrorCode() != 0) {
            LOG.warn("Could not post history event to ATS"
                + ", atsPutError=" + err.getErrorCode()
                + ", entityId=" + entities[i].getEntityId()
                + ", eventType=" + events.get(i).getHistoryEvent().getEventType()
                + ", related entities=" + entities[i].getRelatedEntities().toString());
          }
{code}  
We could change the way to put warn or info message in the case of the error code is 6. 
Back in Yarn the error code 6 is FORBIDDEN_RELATIONSHIP, this situation will not prevent the entity to be put but only the relation will be ignored
{code}
if (!domainId.equals(entity.getDomainId())) {
                // in this case the entity will be put, but the relation will be
                // ignored
                handleError(entity, response, TimelinePutError.FORBIDDEN_RELATION);
                continue;
              }
{code} 

> Timeline related entries missing cause exaggerated warning
> ----------------------------------------------------------
>
>                 Key: TEZ-2179
>                 URL: https://issues.apache.org/jira/browse/TEZ-2179
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.6.1
>            Reporter: Chang Li
>
> Have run into an issue where TimelineClient has posted entities in the timeline event posted. The related entry is not found (i believe because I didn't have generic history turned on) and Yarn timeline server assumes the missing event belongs to the default domain. Regular users don't have permissions to the default domain and so the update to the related entity fails. The posting of the event succeeds, just that the cross-link related entity is not updated. However in the log I will see the warning which is going to scare users
> {code}
> 2015-02-24 20:01:24,526 WARN [HistoryEventHandlingThread] ats.ATSHistoryLoggingService: Could not post history event to ATS, atsPutError=6, entityId=tez_application_1423769157162_273679, eventType=APP_LAUNCHED
> 2015-02-24 20:01:24,526 WARN [HistoryEventHandlingThread] ats.ATSHistoryLoggingService: Could not post history event to ATS, atsPutError=6, entityId=tez_appattempt_1423769157162_273679_000001, eventType=AM_LAUNCHED
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)