You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/01 18:57:56 UTC

[GitHub] [kafka] wenbingshen opened a new pull request #10623: MINOR: Clean up some redundant code from ReplicaManager

wenbingshen opened a new pull request #10623:
URL: https://github.com/apache/kafka/pull/10623


   1. brokerEpoch has been processed in handleStopReplicaRequest, and has no practical effect in ReplicaManager.stopReplicas.
   2. responseMap.put(topicPartition, Errors.forException(e)) has a redundant put in stopReplicas.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #10623: MINOR: Clean up some redundant code from ReplicaManager

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10623:
URL: https://github.com/apache/kafka/pull/10623


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on a change in pull request #10623: MINOR: Clean up some redundant code from ReplicaManager

Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10623:
URL: https://github.com/apache/kafka/pull/10623#discussion_r624721841



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -434,7 +433,6 @@ class ReplicaManager(val config: KafkaConfig,
                 s"controller $controllerId with correlation id $correlationId " +
                 s"epoch $controllerEpoch for partition $topicPartition due to an unexpected " +
                 s"${e.getClass.getName} exception: ${e.getMessage}")
-              responseMap.put(topicPartition, Errors.forException(e))

Review comment:
       nice find




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] wenbingshen commented on pull request #10623: MINOR: Clean up some redundant code from ReplicaManager

Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #10623:
URL: https://github.com/apache/kafka/pull/10623#issuecomment-830764180


   @chia7712 Can you take a look at this pr if you have free time? Thanks, :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org