You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "rawkintrevo (via GitHub)" <gi...@apache.org> on 2023/02/08 15:04:30 UTC
[GitHub] [mahout] rawkintrevo opened a new pull request, #423: MAHOUT-2151 Add Scaladocs to AsFactor.scala
rawkintrevo opened a new pull request, #423:
URL: https://github.com/apache/mahout/pull/423
### Purpose of PR:
Add scaladocs to AsFactor.scala
### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
- [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
- [x] Assigned JIRA to self
- [x] Added documentation in scala docs/java docs, and to website
Does this change break earlier versions?
No
Is this the beginning of a larger project for which a feature branch should be made?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] rawkintrevo commented on a diff in pull request #423: MAHOUT-2151 Add Scaladocs to AsFactor.scala
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #423:
URL: https://github.com/apache/mahout/pull/423#discussion_r1100560952
##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -92,6 +115,12 @@ class AsFactorModel(cardinality: Int, factorVec: MahoutVector) extends Preproces
res
}
+ /**
+ * Inverse transform the input data - ie transform a one-hot encoded DrmLike[K] into a
Review Comment:
not sure how I did that... good eye.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] andrewmusselman merged pull request #423: MAHOUT-2151 Add Scaladocs to AsFactor.scala
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman merged PR #423:
URL: https://github.com/apache/mahout/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] andrewmusselman commented on a diff in pull request #423: MAHOUT-2151 Add Scaladocs to AsFactor.scala
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on code in PR #423:
URL: https://github.com/apache/mahout/pull/423#discussion_r1100492640
##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -29,8 +29,18 @@ import org.apache.mahout.math.scalabindings._
import org.apache.mahout.math.scalabindings.RLikeOps._
import MahoutCollections._
+/**
+ * AsFactor is a preprocessor that turns a vector of integers into a vector of one-hot encoded
Review Comment:
I'd change this to "matrix" instead of "vector of integers"
##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -92,6 +115,12 @@ class AsFactorModel(cardinality: Int, factorVec: MahoutVector) extends Preproces
res
}
+ /**
+ * Inverse transform the input data - ie transform a one-hot encoded DrmLike[K] into a
Review Comment:
I don't know what this method does but that comment doesn't look complete..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mahout] rawkintrevo commented on a diff in pull request #423: MAHOUT-2151 Add Scaladocs to AsFactor.scala
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on code in PR #423:
URL: https://github.com/apache/mahout/pull/423#discussion_r1100556631
##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -29,8 +29,18 @@ import org.apache.mahout.math.scalabindings._
import org.apache.mahout.math.scalabindings.RLikeOps._
import MahoutCollections._
+/**
+ * AsFactor is a preprocessor that turns a vector of integers into a vector of one-hot encoded
Review Comment:
fair- i think it's a matrix of row vectors of integers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org