You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/08/14 15:23:31 UTC
[GitHub] qpid-dispatch pull request #363: Dispatch 1103
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/363
Dispatch 1103
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1103
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #363
----
commit 98156cb32eb7a2d5e40f0a898adc662e83669523
Author: Ganesh Murthy <gm...@...>
Date: 2018-08-13T15:46:52Z
DISPATCH-1099 - Added core timer API
commit a6d1c8727704616bde4575d77e8b537420598151
Author: Ganesh Murthy <gm...@...>
Date: 2018-08-14T15:21:30Z
DISPATCH-1103 - Added code to retry failed auto links using the core timeer API
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #363: Dispatch 1103
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/363#discussion_r212398966
--- Diff: tests/system_tests_autolinks.py ---
@@ -35,6 +36,124 @@
CONNECTION_PROPERTIES = {u'connection': u'properties', u'int_property': 6451}
--- End diff --
Please also provide a test which receives attaches for pre-configured auto-links. Have the test reject the auto-links and see that they retry. Also, have the test accept the auto-link and then detach it to see the retry.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #363: Dispatch 1103
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/363#discussion_r212397739
--- Diff: src/router_core/connections.c ---
@@ -34,6 +34,9 @@ static void qdr_link_delete_CT(qdr_core_t *core, qdr_action_t *action, bool disc
ALLOC_DEFINE(qdr_connection_t);
ALLOC_DEFINE(qdr_connection_work_t);
+const int AUTO_LINK_FIRST_RETRY_INTERVAL = 2;
--- End diff --
All of this auto-link-retry logic should be in the route_control module, not the connections module. One hint that this is the case is the fact that you moved qdr_route_log_CT from static to non-static. qdr_route_log_CT is a static helper function for route_control logic.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #363: Dispatch 1103
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/363
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org