You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/25 09:56:30 UTC

[GitHub] [airflow] bbovenzi commented on a change in pull request #17821: Improve graph view load time for dags with open groups

bbovenzi commented on a change in pull request #17821:
URL: https://github.com/apache/airflow/pull/17821#discussion_r695575356



##########
File path: airflow/www/static/js/graph.js
##########
@@ -598,7 +601,7 @@ function focusGroup(nodeId) {
 }
 
 // Expands a group node
-function expandGroup(nodeId, node, focus = true) {
+function expandGroup(nodeId, node, focus = true, do_draw = true) {

Review comment:
       Could we change the variable to `shouldDraw`?  js should be camelCased and I'm not sure if `do` is a vague verb.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org