You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/07 17:53:54 UTC
[GitHub] [druid] capistrant commented on a change in pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance
capistrant commented on a change in pull request #11960:
URL: https://github.com/apache/druid/pull/11960#discussion_r764235666
##########
File path: web-console/src/druid-models/coordinator-dynamic-config.tsx
##########
@@ -213,14 +213,16 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: Field<CoordinatorDynamicConfig>[
defaultValue: 100,
info: (
<>
- The percentage of the total number of segments in the cluster that are considered every time
- a segment needs to be selected for a move. Druid orders servers by available capacity
- ascending (the least available capacity first) and then iterates over the servers. For each
- server, Druid iterates over the segments on the server, considering them for moving. The
- default config of 100% means that every segment on every server is a candidate to be moved.
- This should make sense for most small to medium-sized clusters. However, an admin may find
- it preferable to drop this value lower if they don't think that it is worthwhile to
- consider every single segment in the cluster each time it is looking for a segment to move.
+ Deprecated. This will be phased out by the batched segment sampler. Only used if
Review comment:
could you clarify what you mean by this? I take it as you asking me to state that the preferred alternative is to set `useBatchedSegmentSampler == true`. so perhaps?
> Deprecated. Will eventually be phased out by the batched segment sampler. You can enable the batched segment sampler now by setting the dynamic Coordinator config, `useBatchedSegmentSampler`, to `true`. Note that if you choose enable the batched segment sampler, this config has no effect on balancing. If `useBatchedSegmentSampler == false`, this config defines the percentage of the total number of segments in the cluster that are considered every time a segment needs to be selected for a move. Druid orders servers by available capacity ascending (the least available capacity first) and then iterates over the servers. For each server, Druid iterates over the segments on the server, considering them for moving. The default config of 100% means that every segment on every server is a candidate to be moved. This should make sense for most small to medium-sized clusters. However, an admin may find it preferable to drop this value lower if they don't think that it is worthwhile to con
sider every single segment in the cluster each time it is looking for a segment to move.|100|
##########
File path: web-console/src/druid-models/coordinator-dynamic-config.tsx
##########
@@ -213,14 +213,16 @@ export const COORDINATOR_DYNAMIC_CONFIG_FIELDS: Field<CoordinatorDynamicConfig>[
defaultValue: 100,
info: (
<>
- The percentage of the total number of segments in the cluster that are considered every time
- a segment needs to be selected for a move. Druid orders servers by available capacity
- ascending (the least available capacity first) and then iterates over the servers. For each
- server, Druid iterates over the segments on the server, considering them for moving. The
- default config of 100% means that every segment on every server is a candidate to be moved.
- This should make sense for most small to medium-sized clusters. However, an admin may find
- it preferable to drop this value lower if they don't think that it is worthwhile to
- consider every single segment in the cluster each time it is looking for a segment to move.
+ Deprecated. This will be phased out by the batched segment sampler. Only used if
Review comment:
could you clarify what you mean by this? I take it as you asking me to state that the preferred alternative is to set `useBatchedSegmentSampler == true`. so perhaps:
> Deprecated. Will eventually be phased out by the batched segment sampler. You can enable the batched segment sampler now by setting the dynamic Coordinator config, `useBatchedSegmentSampler`, to `true`. Note that if you choose enable the batched segment sampler, this config has no effect on balancing. If `useBatchedSegmentSampler == false`, this config defines the percentage of the total number of segments in the cluster that are considered every time a segment needs to be selected for a move. Druid orders servers by available capacity ascending (the least available capacity first) and then iterates over the servers. For each server, Druid iterates over the segments on the server, considering them for moving. The default config of 100% means that every segment on every server is a candidate to be moved. This should make sense for most small to medium-sized clusters. However, an admin may find it preferable to drop this value lower if they don't think that it is worthwhile to con
sider every single segment in the cluster each time it is looking for a segment to move.|100|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org