You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/17 17:44:57 UTC

[GitHub] [spark] dbtsai commented on issue #24865: [SPARK-27100][SQL] dag-scheduler-event-loop" java.lang.StackOverflowError

dbtsai commented on issue #24865: [SPARK-27100][SQL] dag-scheduler-event-loop" java.lang.StackOverflowError
URL: https://github.com/apache/spark/pull/24865#issuecomment-502783225
 
 
   A question I would like to ask is when we should use `Array` instead of `Seq`. We extensively use `Seq` in our codebase because `Seq` is more generic interface. However, in this case, we don't have a control on what is being passed in, and the implementation can be a linked list resulting poor performance in many cases.
   
   In stead of using `Seq` everywhere, should we use `Seq` in function input to keep it generic, but use `Array` in function return?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org