[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #284: Setup so tutorials are deployed to daffodil-site.

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #284: Setup so tutorials are deployed to daffodil-site.
URL: https://github.com/apache/incubator-daffodil/pull/284#discussion_r343306330
 
 

 ##########
 File path: tutorials/src/test/scala/org/apache/daffodil/tutorials/TestTutorials.scala
 ##########
 @@ -26,7 +26,7 @@ object TestTutorials {
   val runner2 = Runner("/", "test1.tutorial.tdml.xml")
   val runner3 = Runner("/", "testTDMLTutorialFile2.tutorial.tdml.xml")
 
 Review comment:
   Maybe only semi related to this change, but no tests are run using the runner3. Should that be delete along with the testTDMLTutorialFile? I'm not sure if that file should has a purpose or if it's just cruft. Also, what is test1.tutorial.tdml? Is that a tutorial or testing the tutorial capabilities? Should it be in src/test/ or maybe it just needs a more descriptive name other than test1?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services