You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Simon MacDonald (JIRA)" <ji...@apache.org> on 2012/09/03 20:47:07 UTC
[jira] [Created] (CB-1366) Reference to PhoneGap still in common.js
Simon MacDonald created CB-1366:
-----------------------------------
Summary: Reference to PhoneGap still in common.js
Key: CB-1366
URL: https://issues.apache.org/jira/browse/CB-1366
Project: Apache Cordova
Issue Type: Bug
Components: CordovaJS
Affects Versions: 2.1.0
Reporter: Simon MacDonald
Assignee: Filip Maj
Priority: Blocker
Fix For: 2.1.0
When looking around for missed references to PhoneGap/phoneGap/phonegap in the Android project I found out that lib/common/common.js still creates a PhoneGap object which is a pointer to cordova.exec.
I'm concerned that this will prevent us from being able to do an official source release from Apache. Can we nuke this section? I don't think it'll hurt anyone as we are forcing everyone to accept the name change. It's been enough releases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1366) Reference to PhoneGap still in
common.js
Posted by "Michael Brooks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447888#comment-13447888 ]
Michael Brooks commented on CB-1366:
------------------------------------
My understanding was the PhoneGap JavaScript object was okay as long as we have a deprecation window set. I could be wrong about that.
> Reference to PhoneGap still in common.js
> ----------------------------------------
>
> Key: CB-1366
> URL: https://issues.apache.org/jira/browse/CB-1366
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 2.1.0
> Reporter: Simon MacDonald
> Assignee: Filip Maj
> Priority: Blocker
> Fix For: 2.1.0
>
>
> When looking around for missed references to PhoneGap/phoneGap/phonegap in the Android project I found out that lib/common/common.js still creates a PhoneGap object which is a pointer to cordova.exec.
> I'm concerned that this will prevent us from being able to do an official source release from Apache. Can we nuke this section? I don't think it'll hurt anyone as we are forcing everyone to accept the name change. It's been enough releases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-1366) Reference to PhoneGap still in
common.js
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-1366.
---------------------------
Resolution: Fixed
Fixed in [143f52|https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=143f5221a6251c9cbccdedc57005c61551b97f12].
> Reference to PhoneGap still in common.js
> ----------------------------------------
>
> Key: CB-1366
> URL: https://issues.apache.org/jira/browse/CB-1366
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 2.1.0
> Reporter: Simon MacDonald
> Assignee: Filip Maj
> Priority: Blocker
> Fix For: 2.1.0
>
>
> When looking around for missed references to PhoneGap/phoneGap/phonegap in the Android project I found out that lib/common/common.js still creates a PhoneGap object which is a pointer to cordova.exec.
> I'm concerned that this will prevent us from being able to do an official source release from Apache. Can we nuke this section? I don't think it'll hurt anyone as we are forcing everyone to accept the name change. It's been enough releases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1366) Reference to PhoneGap still in
common.js
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452504#comment-13452504 ]
Filip Maj commented on CB-1366:
-------------------------------
It has been deprecated for a while. This is fine. If anything I will make sure that the PhoneGap distribution has this in place for 2.1.0.
> Reference to PhoneGap still in common.js
> ----------------------------------------
>
> Key: CB-1366
> URL: https://issues.apache.org/jira/browse/CB-1366
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 2.1.0
> Reporter: Simon MacDonald
> Assignee: Filip Maj
> Priority: Blocker
> Fix For: 2.1.0
>
>
> When looking around for missed references to PhoneGap/phoneGap/phonegap in the Android project I found out that lib/common/common.js still creates a PhoneGap object which is a pointer to cordova.exec.
> I'm concerned that this will prevent us from being able to do an official source release from Apache. Can we nuke this section? I don't think it'll hurt anyone as we are forcing everyone to accept the name change. It's been enough releases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1366) Reference to PhoneGap still in
common.js
Posted by "Brian LeRoux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452776#comment-13452776 ]
Brian LeRoux commented on CB-1366:
----------------------------------
Agree w/ you here Fil. Lets kill this from the Cordova src, and put it back in as a part of COHO (since that will likely go away from here but get maintained by those adobe weridos doing that phonegap distribution thing).
Going to kick up a thread about cutting src distributions the ML.
> Reference to PhoneGap still in common.js
> ----------------------------------------
>
> Key: CB-1366
> URL: https://issues.apache.org/jira/browse/CB-1366
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS
> Affects Versions: 2.1.0
> Reporter: Simon MacDonald
> Assignee: Filip Maj
> Priority: Blocker
> Fix For: 2.1.0
>
>
> When looking around for missed references to PhoneGap/phoneGap/phonegap in the Android project I found out that lib/common/common.js still creates a PhoneGap object which is a pointer to cordova.exec.
> I'm concerned that this will prevent us from being able to do an official source release from Apache. Can we nuke this section? I don't think it'll hurt anyone as we are forcing everyone to accept the name change. It's been enough releases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira