You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2020/07/23 23:17:22 UTC
[GitHub] [madlib] orhankislal opened a new pull request #507: Graph: Fix handling of bigint columns
orhankislal opened a new pull request #507:
URL: https://github.com/apache/madlib/pull/507
JIRA: MADLIB-1444
Graph modules cast the vertex ids to integers in a few spots.
This commit fixes the issue by using bigint type.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. Refer to this link for contribution guidelines https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines
2. Please Provide the Module Name, a JIRA Number and a short description about your changes.
-->
- [ ] Add the module name, JIRA# to PR/commit and description.
- [ ] Add tests for the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] orhankislal merged pull request #507: Graph: Fix handling of bigint columns
Posted by GitBox <gi...@apache.org>.
orhankislal merged pull request #507:
URL: https://github.com/apache/madlib/pull/507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] orhankislal commented on pull request #507: Graph: Fix handling of bigint columns
Posted by GitBox <gi...@apache.org>.
orhankislal commented on pull request #507:
URL: https://github.com/apache/madlib/pull/507#issuecomment-664703769
@fmcquillan99 I pushed a new commit to address these issues. As long as you use the regular SQL BIGINT notation (no trailing L: `100000000014L`, no arithmetic inside the string: `'0+100000000000'`) they all should work now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] fmcquillan99 edited a comment on pull request #507: Graph: Fix handling of bigint columns
Posted by GitBox <gi...@apache.org>.
fmcquillan99 edited a comment on pull request #507:
URL: https://github.com/apache/madlib/pull/507#issuecomment-663917176
I am still seeing failures for HITS, pagerank and wcc. Pls see attached notebooks.
[bigint-notebooks.zip](https://github.com/apache/madlib/files/4976910/bigint-notebooks.zip)
Also user docs still need to be updated to say `INTEGER and `BIGINT` etc. in each module. I can add a commit with the user doc changes to this PR on Mon prob.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] fmcquillan99 commented on pull request #507: Graph: Fix handling of bigint columns
Posted by GitBox <gi...@apache.org>.
fmcquillan99 commented on pull request #507:
URL: https://github.com/apache/madlib/pull/507#issuecomment-664719122
Yes all seem to work now with BIGINT.
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] fmcquillan99 commented on pull request #507: Graph: Fix handling of bigint columns
Posted by GitBox <gi...@apache.org>.
fmcquillan99 commented on pull request #507:
URL: https://github.com/apache/madlib/pull/507#issuecomment-665787058
I just re-tested page rank / personalized pagerank after last commit and it works for me.
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] fmcquillan99 commented on pull request #507: Graph: Fix handling of bigint columns
Posted by GitBox <gi...@apache.org>.
fmcquillan99 commented on pull request #507:
URL: https://github.com/apache/madlib/pull/507#issuecomment-663917176
I am still seeing failures for HITS, pagerank and wcc. Pls see attached notebooks.
[bigint-notebooks.zip](https://github.com/apache/madlib/files/4976910/bigint-notebooks.zip)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] fmcquillan99 edited a comment on pull request #507: Graph: Fix handling of bigint columns
Posted by GitBox <gi...@apache.org>.
fmcquillan99 edited a comment on pull request #507:
URL: https://github.com/apache/madlib/pull/507#issuecomment-663917176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org