You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 14:09:21 UTC

[GitHub] [arrow] paleolimbot opened a new pull request, #14519: ARROW-18043: [R] Properly instantiate empty arrays of extension types in Table__from_schema

paleolimbot opened a new pull request, #14519:
URL: https://github.com/apache/arrow/pull/14519

   This PR supports the following:
   
   ``` r
   library(arrow, warn.conflicts = FALSE)
   #> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.
   
   schema_with_ext_type <- schema(
     x = int32(),
     y = vctrs_extension_type(integer())
   )
   
   as_arrow_table(schema_with_ext_type)
   #> Table
   #> 0 rows x 2 columns
   #> $x <int32>
   #> $y <integer(0)>
   ```
   
   <sup>Created on 2022-10-26 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>
   
   It's a little bit cheating, though, because the previous approach is more true to what `ChunkedArray::MakeEmpty()` does. Is there a downside here to creating a `ChunkedArray` with zero chunks (as opposed to a `ChunkedArray()` with one empty chunk)? If there is we can probably work around it via creating an empty array of the storage type and wrapping it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] thisisnic merged pull request #14519: ARROW-18043: [R] Properly instantiate empty arrays of extension types in Table__from_schema

Posted by GitBox <gi...@apache.org>.
thisisnic merged PR #14519:
URL: https://github.com/apache/arrow/pull/14519


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14519: ARROW-18043: [R] Properly instantiate empty arrays of extension types in Table__from_schema

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14519:
URL: https://github.com/apache/arrow/pull/14519#issuecomment-1295815795

   Benchmark runs are scheduled for baseline = 4e44c1497f799dfd6c34f8b611318a95a078c5ba and contender = e2533ad08ff3b2e52c4da5ff66c5715ad415c026. e2533ad08ff3b2e52c4da5ff66c5715ad415c026 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/63cb51ced1c54a4f9f3fc2f87e14be47...0751367f357f42a7bed5fe2345f27494/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/52e492ee8bb748edb30d929a8203b5b6...a4155b31b84a4931981f1885768b04b6/)
   [Finished :arrow_down:0.54% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/88c2ee5db34b44d0a5e17a04ed32e970...8a6229c595514b128d578c6797be5ed5/)
   [Finished :arrow_down:0.61% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d19df0e054bc40af9c123b3dd942ca74...b23887f0d6294bb2bbfaa3b58bf87522/)
   Buildkite builds:
   [Finished] [`e2533ad0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1776)
   [Failed] [`e2533ad0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1797)
   [Finished] [`e2533ad0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1763)
   [Finished] [`e2533ad0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1789)
   [Finished] [`4e44c149` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1775)
   [Failed] [`4e44c149` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1796)
   [Finished] [`4e44c149` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1762)
   [Finished] [`4e44c149` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1788)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14519: ARROW-18043: [R] Properly instantiate empty arrays of extension types in Table__from_schema

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14519:
URL: https://github.com/apache/arrow/pull/14519#issuecomment-1292281883

   https://issues.apache.org/jira/browse/ARROW-18043


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14519: ARROW-18043: [R] Properly instantiate empty arrays of extension types in Table__from_schema

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14519:
URL: https://github.com/apache/arrow/pull/14519#issuecomment-1292281910

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org