[jira] [Commented] (HIVE-20845) Fix TestJdbcWithDBTokenStoreNoDoAs flakiness

["Peter Vary (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-20845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679096#comment-16679096 ] 

Peter Vary commented on HIVE-20845:
-----------------------------------

The patch contains 2 changes:
* Fix for {{TestJdbcWithDBTokenStore}} - Several more configuration changes done by MiniHS2 init (USE_THRIFT_SASL, KERBEROS_PRINCIPAL, KERBEROS_KEYTAB_FILE) should be set in System properties, so the DriverManager can use them. This fixes the long outstanding issue, that 2 HMS instances is used here
* The MiniHS2 {{waitForStartup}} should wait not only for the possibility to open the session, but for the possibility to open the transport as well. This could be done by using {{DriverManager.getConnection}} instead of {{hs2Client.openSession}}. The {{DriverManager.getConnection}} will open a HiveConnection which calls {{openTransport}} and {{openSession}} as well.

Running tests to see what will happen with the HA passive tests :)

> Fix TestJdbcWithDBTokenStoreNoDoAs flakiness
> --------------------------------------------
>
>                 Key: HIVE-20845
>                 URL: https://issues.apache.org/jira/browse/HIVE-20845
>             Project: Hive
>          Issue Type: Test
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-20845.patch
>
>
> Previously did a dirty fix for TestJdbcWithDBTokenStoreNoDoAs and TestJdbcWithDBTokenStore
> Found out the issue is that we do not wait enough for HS2 to come up.
> Need to fix in MiniHS2.waitForStartup()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)