You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/07/28 07:17:53 UTC
[GitHub] [servicecomb-java-chassis] yanghao605 opened a new pull request, #3238: [SCB-2646] fix metaspace oom problem
yanghao605 opened a new pull request, #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3238: [SCB-2646] fix metaspace oom problem
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238#discussion_r932813092
##########
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java:
##########
@@ -205,7 +211,7 @@ private PriorityProperty<?> createIntProperty(Field field, String[] keys, Intege
private String[] collectPropertyKeys(Field field, String prefix, Map<String, Object> parameters) {
String propertyPrefix = prefix;
- String[] keys = new String[] {field.getName()};
+ String[] keys = new String[]{field.getName()};
Review Comment:
checkstyle changes? How about add this to checkstyle rules? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3238: [SCB-2646] fix metaspace oom problem
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238#discussion_r933916518
##########
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java:
##########
@@ -205,7 +211,7 @@ private PriorityProperty<?> createIntProperty(Field field, String[] keys, Intege
private String[] collectPropertyKeys(Field field, String prefix, Map<String, Object> parameters) {
String propertyPrefix = prefix;
- String[] keys = new String[] {field.getName()};
+ String[] keys = new String[]{field.getName()};
Review Comment:
use formatter in etc foler and then format code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3238: [SCB-2646] fix metaspace oom problem
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238#issuecomment-1198798735
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3238](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1d8e0b) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/281a98e3338d4a99706ef57ead9fbba3467e1425?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (281a98e) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3238 +/- ##
============================================
+ Coverage 77.48% 77.50% +0.02%
Complexity 1439 1439
============================================
Files 1629 1629
Lines 43409 43413 +4
Branches 3652 3652
============================================
+ Hits 33634 33647 +13
+ Misses 8269 8260 -9
Partials 1506 1506
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rvicecomb/config/priority/ConfigObjectFactory.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9wcmlvcml0eS9Db25maWdPYmplY3RGYWN0b3J5LmphdmE=) | `90.42% <100.00%> (+0.42%)` | :arrow_up: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `70.93% <0.00%> (+0.76%)` | :arrow_up: |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `10.63% <0.00%> (+1.06%)` | :arrow_up: |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `80.37% <0.00%> (+1.86%)` | :arrow_up: |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3238/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3238: [SCB-2646] fix metaspace oom problem
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238#discussion_r932813092
##########
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java:
##########
@@ -205,7 +211,7 @@ private PriorityProperty<?> createIntProperty(Field field, String[] keys, Intege
private String[] collectPropertyKeys(Field field, String prefix, Map<String, Object> parameters) {
String propertyPrefix = prefix;
- String[] keys = new String[] {field.getName()};
+ String[] keys = new String[]{field.getName()};
Review Comment:
checkstyle changes? Why not detected by checktsyle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] yanghao605 commented on a diff in pull request #3238: [SCB-2646] fix metaspace oom problem
Posted by GitBox <gi...@apache.org>.
yanghao605 commented on code in PR #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238#discussion_r932990981
##########
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java:
##########
@@ -205,7 +211,7 @@ private PriorityProperty<?> createIntProperty(Field field, String[] keys, Intege
private String[] collectPropertyKeys(Field field, String prefix, Map<String, Object> parameters) {
String propertyPrefix = prefix;
- String[] keys = new String[] {field.getName()};
+ String[] keys = new String[]{field.getName()};
Review Comment:
should I add a space?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3238: [SCB-2646] fix metaspace oom problem
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238#discussion_r933916932
##########
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/priority/ConfigObjectFactory.java:
##########
@@ -95,7 +100,8 @@ public List<ConfigObjectProperty> createProperties(Object instance, String prefi
continue;
}
- Setter<Object, Object> setter = createObjectSetter(propertyDefinition);
+ Setter<Object, Object> setter = beanDescriptionCache.computeIfAbsent(propertyDefinition,
+ LambdaMetafactoryUtils::createObjectSetter);
Review Comment:
import static org.apache.servicecomb.foundation.common.utils.LambdaMetafactoryUtils.createObjectSetter can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3238: [SCB-2646] fix metaspace oom problem
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3238:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org