[GitHub] guacamole-client pull request #254: GUACAMOLE-103: Implement SAML Authentica...

[necouchman <gi...@git.apache.org>]

Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/254#discussion_r198765764
  
    --- Diff: extensions/guacamole-auth-saml/src/main/java/org/apache/guacamole/auth/saml/conf/ConfigurationService.java ---
    @@ -0,0 +1,223 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.auth.saml.conf;
    +
    +import com.google.inject.Inject;
    +import com.onelogin.saml2.settings.Saml2Settings;
    +import com.onelogin.saml2.settings.SettingsBuilder;
    +import java.io.File;
    +import java.net.URL;
    +import java.util.HashMap;
    +import java.util.Map;
    +import org.apache.guacamole.GuacamoleException;
    +import org.apache.guacamole.environment.Environment;
    +import org.apache.guacamole.properties.FileGuacamoleProperty;
    +import org.apache.guacamole.properties.StringGuacamoleProperty;
    +import org.apache.guacamole.properties.UrlGuacamoleProperty;
    +
    +/**
    + * Service for retrieving configuration information regarding the SAML
    + * authentication module.
    + */
    +public class ConfigurationService {
    +
    +    /**
    +     * The file containing the XML Metadata associated with the SAML IdP.
    +     */
    +    private static final FileGuacamoleProperty SAML_IDP_METADATA =
    +            new FileGuacamoleProperty() {
    +
    +        @Override
    +        public String getName() { return "saml-idp-metadata"; }
    --- End diff --
    
    This is now implemented - OneLogin released version 2.3.0 of their Java SAML client, which includes this capability.


---