You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2014/06/18 01:15:28 UTC
[jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Note - still missing adding these to the createVolume* methods, but
that's going to involve a non-trivial change to something like
CreateVolumeOptions.class rather than the current simple arguments.
You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-1 jclouds-602
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/408
-- Commit Summary --
* JCLOUDS-602 - Add support for volumeType, iops and encrypted to EC2 volumes
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/compute/options/EC2TemplateOptions.java (19)
M apis/ec2/src/main/java/org/jclouds/ec2/domain/BlockDeviceMapping.java (82)
M apis/ec2/src/main/java/org/jclouds/ec2/domain/Volume.java (75)
M apis/ec2/src/main/java/org/jclouds/ec2/options/RunInstancesOptions.java (8)
M apis/ec2/src/main/java/org/jclouds/ec2/xml/CreateVolumeResponseHandler.java (29)
M apis/ec2/src/test/java/org/jclouds/ec2/features/EC2ElasticBlockStoreApiExpectTest.java (40)
M apis/ec2/src/test/java/org/jclouds/ec2/options/RunInstancesOptionsTest.java (12)
M apis/ec2/src/test/java/org/jclouds/ec2/xml/CreateVolumeResponseHandlerTest.java (6)
M apis/ec2/src/test/java/org/jclouds/ec2/xml/DescribeVolumesResponseHandlerTest.java (13)
M apis/ec2/src/test/resources/created_volume.xml (3)
M apis/ec2/src/test/resources/describe_volumes.xml (6)
M apis/ec2/src/test/resources/describe_volumes_single.xml (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/domain/LaunchSpecification.java (17)
M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/options/AWSRunInstancesOptionsTest.java (10)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/408.patch
https://github.com/jclouds/jclouds/pull/408.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
The jclouds-pull-requests build 906 failure looks spurious - will wait and see if the others barf too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46509445
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
> @@ -160,6 +163,24 @@ void testCreateVolumeFromSnapshotInAvailabilityZone() {
> }
>
> @Test(dependsOnMethods = "testCreateSnapshotInRegion")
> + void testCreateVolumeFromSnapshotInAvailabilityZoneWithOptions() {
> + Volume volume = client.createVolumeInAvailabilityZone(defaultZone,
> + CreateVolumeOptions.Builder.fromSnapshotId(snapshot.getId()));
nit: cluttery, I'd statik import the mofo
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947792
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1377](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1377/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46511695
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
sfsg keep on truckin
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46510530
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
> @@ -159,11 +159,18 @@ public static ImageType fromValue(String v) {
> private final String snapshotId;
> private final long volumeSize;
> private final boolean deleteOnTermination;
> + private final String volumeType;
> + private final Integer iops;
> + private final boolean encrypted;
sounds good as long as base cases don't emit (sincethis code is in api/ec2 not provider/aws-ec2). ex. if switching iops to primitive, make sure the base case of zero doesn't emit a query, since that's probably in a later api version, and might puke a clone.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13948012
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
> + @Nullable Boolean deleteOnTermination,
> + @Nullable String volumeType,
> + @Nullable Integer iops,
> + @Nullable Boolean encrypted) {
> + addAdvancedEbsOptions(deleteOnTermination, volumeType, iops, encrypted);
> + addNewEphemeralBlockDevice(deviceName, virtualName, volumeSize);
> +
> + return this;
> + }
> +
> + private RegisterImageBackedByEbsOptions addAdvancedEbsOptions(@Nullable Boolean deleteOnTermination,
> + @Nullable String volumeType,
> + @Nullable Integer iops,
> + @Nullable Boolean encrypted) {
> + if (deleteOnTermination == null)
> + deleteOnTermination = false;
if the defaults for delete and encrypt are false, I'd probably use primitives and only add the param on true (universally)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947674
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1238](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1238/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46381794
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1380](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1380/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46602943
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
> - .id("vol-2a21e543")
> - .status(Volume.Status.CREATING)
> - .availabilityZone("us-east-1a")
> - .region("us-east-1")
> - .id("vol-2a21e543")
> - .size(1)
> - .createTime(dateService.iso8601DateParse("2009-12-28T05:42:53.000Z"))
> - .build();
> + .id("vol-2a21e543")
> + .status(Volume.Status.CREATING)
> + .availabilityZone("us-east-1a")
> + .region("us-east-1")
> + .id("vol-2a21e543")
> + .volumeType("standard")
> + .iops(0)
> + .encrypted(false)
yeah so not sure about value of setting false, except maybe clones might not puke on it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947758
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1371](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1371/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46380152
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
Add CreateVolumeOptions, modified everything that I could find that cares about parsing or creating volumes (and EBS-backed images, since that's connected) to support the new fields as well. Live tests and unit tests should be updated.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46509407
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #906](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/906/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46509389
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #912](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/912/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46624776
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1250](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1250/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46604556
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
>
> - public EbsBlockDevice(@Nullable String snapshotId, long volumeSize, boolean deleteOnTermination) {
> + public EbsBlockDevice(@Nullable String snapshotId, long volumeSize, boolean deleteOnTermination,
For new classes, oh yeah, lots of wonderful new things without even going *that* far. =) But with existing classes, I tend to just work with what they got.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947902
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #913](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/913/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46637358
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
> @@ -139,6 +139,14 @@ public RunInstancesOptions withBlockDeviceMappings(Set<? extends BlockDeviceMapp
> if (mapping.getEbsDeleteOnTermination() != null)
> formParameters.put(String.format("BlockDeviceMapping.%d.Ebs.DeleteOnTermination", i),
> String.valueOf(mapping.getEbsDeleteOnTermination()));
> + if (mapping.getEbsVolumeType() != null)
> + formParameters.put(String.format("BlockDeviceMapping.%d.Ebs.VolumeType", i), mapping.getEbsVolumeType());
> + if (mapping.getEbsIops() != null)
> + formParameters.put(String.format("BlockDeviceMapping.%d.Ebs.Iops", i),
> + String.valueOf(mapping.getEbsIops()));
> + if (mapping.getEbsEncrypted() != null && mapping.getEbsEncrypted() != false)
doo doo doot doot doo doo doo doot doot, truthy dance!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947948
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
> @@ -159,11 +159,18 @@ public static ImageType fromValue(String v) {
> private final String snapshotId;
> private final long volumeSize;
> private final boolean deleteOnTermination;
> + private final String volumeType;
> + private final Integer iops;
> + private final boolean encrypted;
if this is primitive type, I'd probably set the other uses of `encrypted` to primitive as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947549
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1384](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1384/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46637429
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
> @@ -160,6 +163,24 @@ void testCreateVolumeFromSnapshotInAvailabilityZone() {
> }
>
> @Test(dependsOnMethods = "testCreateSnapshotInRegion")
> + void testCreateVolumeFromSnapshotInAvailabilityZoneWithOptions() {
> + Volume volume = client.createVolumeInAvailabilityZone(defaultZone,
> + CreateVolumeOptions.Builder.fromSnapshotId(snapshot.getId()));
> + assertNotNull(volume);
> +
> + Predicate<Volume> availabile = retry(new VolumeAvailable(client), 600, 10, SECONDS);
> + assert availabile.apply(volume);
> +
> + Volume result = Iterables.getOnlyElement(client.describeVolumesInRegion(snapshot.getRegion(), volume.getId()));
> + assertEquals(volume.getId(), result.getId());
aside: start using (or writing custom) assertj assertions
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947874
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #909](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/909/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46602774
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
Review comments addressed - it's still a little wishy-washy on primitive/non-primitive for encrypted, because there are a few places where it frankly makes sense to go with nullable Booleans, but it's much more consistent now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46598216
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1252](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1252/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46623104
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
> - .id("vol-2a21e543")
> - .status(Volume.Status.CREATING)
> - .availabilityZone("us-east-1a")
> - .region("us-east-1")
> - .id("vol-2a21e543")
> - .size(1)
> - .createTime(dateService.iso8601DateParse("2009-12-28T05:42:53.000Z"))
> - .build();
> + .id("vol-2a21e543")
> + .status(Volume.Status.CREATING)
> + .availabilityZone("us-east-1a")
> + .region("us-east-1")
> + .id("vol-2a21e543")
> + .volumeType("standard")
> + .iops(0)
> + .encrypted(false)
I just did it without thinking. =)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947960
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
> @@ -160,6 +163,24 @@ void testCreateVolumeFromSnapshotInAvailabilityZone() {
> }
>
> @Test(dependsOnMethods = "testCreateSnapshotInRegion")
> + void testCreateVolumeFromSnapshotInAvailabilityZoneWithOptions() {
> + Volume volume = client.createVolumeInAvailabilityZone(defaultZone,
> + CreateVolumeOptions.Builder.fromSnapshotId(snapshot.getId()));
Reasonable.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947971
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
> @@ -139,6 +139,14 @@ public RunInstancesOptions withBlockDeviceMappings(Set<? extends BlockDeviceMapp
> if (mapping.getEbsDeleteOnTermination() != null)
> formParameters.put(String.format("BlockDeviceMapping.%d.Ebs.DeleteOnTermination", i),
> String.valueOf(mapping.getEbsDeleteOnTermination()));
> + if (mapping.getEbsVolumeType() != null)
> + formParameters.put(String.format("BlockDeviceMapping.%d.Ebs.VolumeType", i), mapping.getEbsVolumeType());
> + if (mapping.getEbsIops() != null)
> + formParameters.put(String.format("BlockDeviceMapping.%d.Ebs.Iops", i),
> + String.valueOf(mapping.getEbsIops()));
> + if (mapping.getEbsEncrypted() != null && mapping.getEbsEncrypted() != false)
yeah because of the truthy dance
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947704
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #911](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/911/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46621876
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1383](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1383/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46625001
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1262](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1262/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46727664
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
Whoops again - ran the full battery of live tests, found another problem - we do need the truthy dance for now, unless we switch BlockDeviceMapping to primitives for encrypted, and I'm not going to do that unless I know why deleteOnTermination's a non-primitive there.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46635940
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
> + @Nullable Boolean deleteOnTermination,
> + @Nullable String volumeType,
> + @Nullable Integer iops,
> + @Nullable Boolean encrypted) {
> + addAdvancedEbsOptions(deleteOnTermination, volumeType, iops, encrypted);
> + addNewEphemeralBlockDevice(deviceName, virtualName, volumeSize);
> +
> + return this;
> + }
> +
> + private RegisterImageBackedByEbsOptions addAdvancedEbsOptions(@Nullable Boolean deleteOnTermination,
> + @Nullable String volumeType,
> + @Nullable Integer iops,
> + @Nullable Boolean encrypted) {
> + if (deleteOnTermination == null)
> + deleteOnTermination = false;
I think I was trying to avoid adding the form field if it wasn't necessary and did it in a kind of ass-backwards way. Will clean up.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947929
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
Live tests are added and passing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46617134
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
Oops, one test was a bit flaky. Fixed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46618857
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
> @@ -159,11 +159,18 @@ public static ImageType fromValue(String v) {
> private final String snapshotId;
> private final long volumeSize;
> private final boolean deleteOnTermination;
> + private final String volumeType;
> + private final Integer iops;
> + private final boolean encrypted;
Actually, I should probably change it all to primitive - I was going with non-primitive for places where it's optional, but I think it actually shows up in every EBS volume query now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947879
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #900](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/900/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46381604
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Andrew Bayer <no...@github.com>.
> @@ -159,11 +159,18 @@ public static ImageType fromValue(String v) {
> private final String snapshotId;
> private final long volumeSize;
> private final boolean deleteOnTermination;
> + private final String volumeType;
> + private final Integer iops;
> + private final boolean encrypted;
I'm going to leave Iops as a non-primitive everywhere, because it's possible (though I don't think likely) that it could have a 0 value. I'm going to move encrypted to a primitive where it makes sense - i.e., in BlockDeviceMapping, deleteOnTermination is a non-primitive already, so I'll stick witht he same thing there.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13981341
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1382](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1382/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46622156
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by Adrian Cole <no...@github.com>.
>
> - public EbsBlockDevice(@Nullable String snapshotId, long volumeSize, boolean deleteOnTermination) {
> + public EbsBlockDevice(@Nullable String snapshotId, long volumeSize, boolean deleteOnTermination,
aside: consider auto-value to write this class, including its tostring etc :)
https://github.com/google/auto/tree/master/value
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408/files#r13947588
Re: [jclouds] JCLOUDS-602 - Add support for volumeType, iops and
encrypted to EC2 volumes (#408)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1253](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1253/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/408#issuecomment-46627604