You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/05/28 00:38:00 UTC
[GitHub] [samza] shekhars-li opened a new pull request #1503: Fix StorageConfig bug from newly introduced BlobStoreRestore factory config
shekhars-li opened a new pull request #1503:
URL: https://github.com/apache/samza/pull/1503
Description:
Newly introduced config `store.restore.factory` falls in the same pattern as StorageEngine config defined by `store.<store_name>.factory`. This fix and a follow up todo ignored `store.restore.factory` from `getStorageFactoryClassName` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] prateekm merged pull request #1503: Fix StorageConfig bug from newly introduced BlobStoreRestore factory config
Posted by GitBox <gi...@apache.org>.
prateekm merged pull request #1503:
URL: https://github.com/apache/samza/pull/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] dxichen commented on a change in pull request #1503: Fix StorageConfig bug from newly introduced BlobStoreRestore factory config
Posted by GitBox <gi...@apache.org>.
dxichen commented on a change in pull request #1503:
URL: https://github.com/apache/samza/pull/1503#discussion_r641077464
##########
File path: samza-core/src/main/java/org/apache/samza/config/StorageConfig.java
##########
@@ -153,6 +153,10 @@ public int getAccessLogSamplingRatio(String storeName) {
}
public Optional<String> getStorageFactoryClassName(String storeName) {
+ //TODO HIGH dchen remove this after changing restore factory to factories.
Review comment:
I don't think this will fix it, you would likely have to change `getStoreNames` so it does not return the store restore/backend factory config as the store name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org