You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/08/07 22:47:46 UTC
Review Request 61483: Added a test using CMD health checks +
DefaultExecutor w/ Docker image.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61483/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Vinod Kone.
Repository: mesos
Description
-------
Added a test using CMD health checks + DefaultExecutor w/ Docker image.
Diffs
-----
src/tests/health_check_tests.cpp e824d1b2c2b17423394da0b089ae8940450378b7
Diff: https://reviews.apache.org/r/61483/diff/1/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="HealthCheckTest.DefaultExecutorWithDockerImageCommandHealthCheck"`
Thanks,
Gastón Kleiman
Re: Review Request 61483: Added a test using CMD health checks +
DefaultExecutor w/ Docker image.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61483/#review182416
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 7, 2017, 10:47 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61483/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test using CMD health checks + DefaultExecutor w/ Docker image.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp e824d1b2c2b17423394da0b089ae8940450378b7
>
>
> Diff: https://reviews.apache.org/r/61483/diff/1/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="HealthCheckTest.DefaultExecutorWithDockerImageCommandHealthCheck"`
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 61483: Added a test using CMD health checks +
DefaultExecutor w/ Docker image.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61483/#review182980
-----------------------------------------------------------
Ship it!
src/tests/health_check_tests.cpp
Lines 2458 (patched)
<https://reviews.apache.org/r/61483/#comment258959>
This is how one can still leave traces in the codebase long after abandoning the project : )
- Alexander Rukletsov
On Aug. 7, 2017, 10:47 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61483/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test using CMD health checks + DefaultExecutor w/ Docker image.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp e824d1b2c2b17423394da0b089ae8940450378b7
>
>
> Diff: https://reviews.apache.org/r/61483/diff/1/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="HealthCheckTest.DefaultExecutorWithDockerImageCommandHealthCheck"`
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 61483: Added a test using CMD health checks +
DefaultExecutor w/ Docker image.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61483/#review182982
-----------------------------------------------------------
Bad patch!
Reviews applied: [61483, 61438, 61282]
Failed command: python support/apply-reviews.py -n -r 61282
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 417, in <module>
main()
File "support/apply-reviews.py", line 412, in main
reviewboard(options)
File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 160, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 268, in commit_patch
shell(cmd, options['dry_run'])
File "support/apply-reviews.py", line 144, in shell
error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
File "C:\Python27\lib\subprocess.py", line 168, in call
return Popen(*popenargs, **kwargs).wait()
File "C:\Python27\lib\subprocess.py", line 390, in __init__
errread, errwrite)
File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/231/console
- Mesos Reviewbot Windows
On Aug. 7, 2017, 10:47 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61483/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test using CMD health checks + DefaultExecutor w/ Docker image.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp e824d1b2c2b17423394da0b089ae8940450378b7
>
>
> Diff: https://reviews.apache.org/r/61483/diff/1/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="HealthCheckTest.DefaultExecutorWithDockerImageCommandHealthCheck"`
>
>
> Thanks,
>
> Gastón Kleiman
>
>