You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by Lewis John Mcgibbney <le...@gmail.com> on 2011/12/08 22:36:02 UTC
Taking notice of community comments
Hi Guys,
If you take a look at this thread here [1], Sebb and others kindly offered
various opinions prior to the 0.1-incubating release. In summary these were
with regards to the following
1) The source distribution (or any )should not include all the .gitignore
files, I'm aware that Gora was originally (solely) hosted on GitHub but not
anymore so is it possible to remove these?
2) The fact that we are still shipping with several jars in SVN, when we
come round to pushing a release these will also be in the source archive.
The offending ones are
- cassandra-all-0.8.0.jar
- hector-core-0.8.0-1.jar
- thrift-0.2.0.jar
- ivy-2.1.0.jar
Can these be removed? I am firmly for the vote to remove the ones in
gora-cassandra module as we now suppport Cassandra 1.X, what about
gora-hbase? As the Ivy stuff is not being maintained does anyone have a
preference on this?
Thanks
Lewis
[1]
http://old.nabble.com/-VOTE--Release-Apache-Gora-0.1-incubating-rc3-td31186845.html
--
*Lewis*
Re: Taking notice of community comments
Posted by Lewis John Mcgibbney <le...@gmail.com>.
Hi Enis,
.gitignore files have now been added back into SVN area. Apologies for
taking so long to get this reverted.
Committed @ r1227267 in trunk
Thanks
Lewis
On Thu, Dec 15, 2011 at 12:26 PM, Lewis John Mcgibbney
<le...@gmail.com> wrote:
> OK so to clarify.
>
> I've removed the extra jar files which were littering the place. I've
> also removed the .gitignore files whereever I saw them. I'll revert
> the .gitignore files for the reasons you mention as they are more than
> justified Enis.
>
> Thanks
>
> Lewis
>
> On Wed, Dec 14, 2011 at 8:01 PM, Enis Söztutar <en...@gmail.com> wrote:
>> Thanks Lewis for taking care of this. I agree that we should remove the
>> extra jars, and cleanup the unnecessary files. The only thing is that,
>> since we should continue supporting the git repo, when you check out the
>> code from git://git.apache.org/gora.gitthat we should be able to compile
>> and run the unit tests.
>>
>> We may opt to keep the .gitignore (and similar) files in the repo, but not
>> release them in the tarball, but it is too much of a hassle to maintain
>> this. Besides I think of .gitignore files as a part of the code (since it
>> configures your build structure), so we can release them together with the
>> code in the tarball.
>>
>> Thanks.
>> Enis
>>
>> On Tue, Dec 13, 2011 at 3:22 AM, Lewis John Mcgibbney <
>> lewis.mcgibbney@gmail.com> wrote:
>>
>>> Hi Enis,
>>>
>>> No I'm not using Git, but realise that a few of you were/are,
>>> therefore I am more than happy for you to revert the changes I made to
>>> suit those Git repos users.
>>>
>>> If there is anything else I can do then please say and I will help to
>>> make the necessary changes.
>>>
>>> Thanks
>>>
>>> On Mon, Dec 12, 2011 at 10:56 PM, Enis Söztutar <en...@gmail.com>
>>> wrote:
>>> > Hi,
>>> >
>>> > I think we should keep the .gitignore files, and revert the commit for
>>> > this. The git/svn flame wars is still very hot in members@, but even if
>>> we
>>> > will not have read/write git access, we will always have at least
>>> read-only
>>> > git access at git.apache.org. Some people (like me) prefer to use git as
>>> > their main tool, and we have a git repo at
>>> > git://git.apache.org/gora.gitthat we should support. Besides, the
>>> > release CAN and SHOULD include the
>>> > .gitignore files for git to work correctly.
>>> >
>>> > Normally, we do not need more than the top level .gitignore, but since
>>> for
>>> > the build to work with ant, we needed those empty dirs at
>>> > (gora-xxx/lib-ext, etc), and since git does not track empty dirs, the
>>> > default way to add them to repo is to add an empty .gitignore. Now that
>>> we
>>> > have switched to maven, we probably do not need some of those dirs, so I
>>> > propose to revert the commit, and selectively do remove the ones not
>>> > needed. One more reason to revert the change is that the patch for issue
>>> > GORA-63 seems to be accidentally committed at
>>> > gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java.
>>> >
>>> > Lewis, are you using the git repo. If not, I can do the changes if you
>>> > prefer.
>>> >
>>> > Thanks,
>>> > Enis
>>> >
>>> > On Sun, Dec 11, 2011 at 1:01 PM, Lewis John Mcgibbney <
>>> > lewis.mcgibbney@gmail.com> wrote:
>>> >
>>> >> Hi,
>>> >>
>>> >> You should be able to see this has now been addressed and Committed @
>>> >> revision 1213062 in trunk.
>>> >>
>>> >> Thanks
>>> >>
>>> >> Lewis
>>> >>
>>> >> On Thu, Dec 8, 2011 at 10:16 PM, Lewis John Mcgibbney
>>> >> <le...@gmail.com> wrote:
>>> >> > OK please see below
>>> >> >>
>>> >> >>
>>> >> >> Yeah we can remove the .gitnore files, feel free to svn remove them,
>>> +1.
>>> >> >
>>> >> > will do
>>> >> >
>>> >> >>
>>> >> >>
>>> >> >> I'd like to move away from having any of these files in trunk since
>>> we
>>> >> >> don't
>>> >> >> need them as they are all available on Central right? Let's get rid
>>> of
>>> >> >> them...
>>> >> >
>>> >> > Yeah, we've moved completely away from the cassandra and hector
>>> versions
>>> >> and
>>> >> > now support 1.X, in addition this thrift jar looks pretty our of
>>> place as
>>> >> > I've upgraded the HBase dependency to 0.90.4 (latest stable as well).
>>> >> >
>>> >> > I'll look into it and get a Jira logged and patch submitted.
>>> >> >
>>> >> > ta
>>> >> >
>>> >> >>
>>> >> >>
>>> >> >> Cheers,
>>> >> >> Chris
>>> >> >>
>>> >> > Thanks
>>> >> > Lewis
>>> >> >
>>> >> >
>>> >> > --
>>> >> > Lewis
>>> >> >
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Lewis
>>> >>
>>>
>>>
>>>
>>> --
>>> Lewis
>>>
>
>
>
> --
> Lewis
--
Lewis
Re: Taking notice of community comments
Posted by Lewis John Mcgibbney <le...@gmail.com>.
OK so to clarify.
I've removed the extra jar files which were littering the place. I've
also removed the .gitignore files whereever I saw them. I'll revert
the .gitignore files for the reasons you mention as they are more than
justified Enis.
Thanks
Lewis
On Wed, Dec 14, 2011 at 8:01 PM, Enis Söztutar <en...@gmail.com> wrote:
> Thanks Lewis for taking care of this. I agree that we should remove the
> extra jars, and cleanup the unnecessary files. The only thing is that,
> since we should continue supporting the git repo, when you check out the
> code from git://git.apache.org/gora.gitthat we should be able to compile
> and run the unit tests.
>
> We may opt to keep the .gitignore (and similar) files in the repo, but not
> release them in the tarball, but it is too much of a hassle to maintain
> this. Besides I think of .gitignore files as a part of the code (since it
> configures your build structure), so we can release them together with the
> code in the tarball.
>
> Thanks.
> Enis
>
> On Tue, Dec 13, 2011 at 3:22 AM, Lewis John Mcgibbney <
> lewis.mcgibbney@gmail.com> wrote:
>
>> Hi Enis,
>>
>> No I'm not using Git, but realise that a few of you were/are,
>> therefore I am more than happy for you to revert the changes I made to
>> suit those Git repos users.
>>
>> If there is anything else I can do then please say and I will help to
>> make the necessary changes.
>>
>> Thanks
>>
>> On Mon, Dec 12, 2011 at 10:56 PM, Enis Söztutar <en...@gmail.com>
>> wrote:
>> > Hi,
>> >
>> > I think we should keep the .gitignore files, and revert the commit for
>> > this. The git/svn flame wars is still very hot in members@, but even if
>> we
>> > will not have read/write git access, we will always have at least
>> read-only
>> > git access at git.apache.org. Some people (like me) prefer to use git as
>> > their main tool, and we have a git repo at
>> > git://git.apache.org/gora.gitthat we should support. Besides, the
>> > release CAN and SHOULD include the
>> > .gitignore files for git to work correctly.
>> >
>> > Normally, we do not need more than the top level .gitignore, but since
>> for
>> > the build to work with ant, we needed those empty dirs at
>> > (gora-xxx/lib-ext, etc), and since git does not track empty dirs, the
>> > default way to add them to repo is to add an empty .gitignore. Now that
>> we
>> > have switched to maven, we probably do not need some of those dirs, so I
>> > propose to revert the commit, and selectively do remove the ones not
>> > needed. One more reason to revert the change is that the patch for issue
>> > GORA-63 seems to be accidentally committed at
>> > gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java.
>> >
>> > Lewis, are you using the git repo. If not, I can do the changes if you
>> > prefer.
>> >
>> > Thanks,
>> > Enis
>> >
>> > On Sun, Dec 11, 2011 at 1:01 PM, Lewis John Mcgibbney <
>> > lewis.mcgibbney@gmail.com> wrote:
>> >
>> >> Hi,
>> >>
>> >> You should be able to see this has now been addressed and Committed @
>> >> revision 1213062 in trunk.
>> >>
>> >> Thanks
>> >>
>> >> Lewis
>> >>
>> >> On Thu, Dec 8, 2011 at 10:16 PM, Lewis John Mcgibbney
>> >> <le...@gmail.com> wrote:
>> >> > OK please see below
>> >> >>
>> >> >>
>> >> >> Yeah we can remove the .gitnore files, feel free to svn remove them,
>> +1.
>> >> >
>> >> > will do
>> >> >
>> >> >>
>> >> >>
>> >> >> I'd like to move away from having any of these files in trunk since
>> we
>> >> >> don't
>> >> >> need them as they are all available on Central right? Let's get rid
>> of
>> >> >> them...
>> >> >
>> >> > Yeah, we've moved completely away from the cassandra and hector
>> versions
>> >> and
>> >> > now support 1.X, in addition this thrift jar looks pretty our of
>> place as
>> >> > I've upgraded the HBase dependency to 0.90.4 (latest stable as well).
>> >> >
>> >> > I'll look into it and get a Jira logged and patch submitted.
>> >> >
>> >> > ta
>> >> >
>> >> >>
>> >> >>
>> >> >> Cheers,
>> >> >> Chris
>> >> >>
>> >> > Thanks
>> >> > Lewis
>> >> >
>> >> >
>> >> > --
>> >> > Lewis
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Lewis
>> >>
>>
>>
>>
>> --
>> Lewis
>>
--
Lewis
Re: Taking notice of community comments
Posted by Enis Söztutar <en...@gmail.com>.
Thanks Lewis for taking care of this. I agree that we should remove the
extra jars, and cleanup the unnecessary files. The only thing is that,
since we should continue supporting the git repo, when you check out the
code from git://git.apache.org/gora.gitthat we should be able to compile
and run the unit tests.
We may opt to keep the .gitignore (and similar) files in the repo, but not
release them in the tarball, but it is too much of a hassle to maintain
this. Besides I think of .gitignore files as a part of the code (since it
configures your build structure), so we can release them together with the
code in the tarball.
Thanks.
Enis
On Tue, Dec 13, 2011 at 3:22 AM, Lewis John Mcgibbney <
lewis.mcgibbney@gmail.com> wrote:
> Hi Enis,
>
> No I'm not using Git, but realise that a few of you were/are,
> therefore I am more than happy for you to revert the changes I made to
> suit those Git repos users.
>
> If there is anything else I can do then please say and I will help to
> make the necessary changes.
>
> Thanks
>
> On Mon, Dec 12, 2011 at 10:56 PM, Enis Söztutar <en...@gmail.com>
> wrote:
> > Hi,
> >
> > I think we should keep the .gitignore files, and revert the commit for
> > this. The git/svn flame wars is still very hot in members@, but even if
> we
> > will not have read/write git access, we will always have at least
> read-only
> > git access at git.apache.org. Some people (like me) prefer to use git as
> > their main tool, and we have a git repo at
> > git://git.apache.org/gora.gitthat we should support. Besides, the
> > release CAN and SHOULD include the
> > .gitignore files for git to work correctly.
> >
> > Normally, we do not need more than the top level .gitignore, but since
> for
> > the build to work with ant, we needed those empty dirs at
> > (gora-xxx/lib-ext, etc), and since git does not track empty dirs, the
> > default way to add them to repo is to add an empty .gitignore. Now that
> we
> > have switched to maven, we probably do not need some of those dirs, so I
> > propose to revert the commit, and selectively do remove the ones not
> > needed. One more reason to revert the change is that the patch for issue
> > GORA-63 seems to be accidentally committed at
> > gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java.
> >
> > Lewis, are you using the git repo. If not, I can do the changes if you
> > prefer.
> >
> > Thanks,
> > Enis
> >
> > On Sun, Dec 11, 2011 at 1:01 PM, Lewis John Mcgibbney <
> > lewis.mcgibbney@gmail.com> wrote:
> >
> >> Hi,
> >>
> >> You should be able to see this has now been addressed and Committed @
> >> revision 1213062 in trunk.
> >>
> >> Thanks
> >>
> >> Lewis
> >>
> >> On Thu, Dec 8, 2011 at 10:16 PM, Lewis John Mcgibbney
> >> <le...@gmail.com> wrote:
> >> > OK please see below
> >> >>
> >> >>
> >> >> Yeah we can remove the .gitnore files, feel free to svn remove them,
> +1.
> >> >
> >> > will do
> >> >
> >> >>
> >> >>
> >> >> I'd like to move away from having any of these files in trunk since
> we
> >> >> don't
> >> >> need them as they are all available on Central right? Let's get rid
> of
> >> >> them...
> >> >
> >> > Yeah, we've moved completely away from the cassandra and hector
> versions
> >> and
> >> > now support 1.X, in addition this thrift jar looks pretty our of
> place as
> >> > I've upgraded the HBase dependency to 0.90.4 (latest stable as well).
> >> >
> >> > I'll look into it and get a Jira logged and patch submitted.
> >> >
> >> > ta
> >> >
> >> >>
> >> >>
> >> >> Cheers,
> >> >> Chris
> >> >>
> >> > Thanks
> >> > Lewis
> >> >
> >> >
> >> > --
> >> > Lewis
> >> >
> >>
> >>
> >>
> >> --
> >> Lewis
> >>
>
>
>
> --
> Lewis
>
Re: Taking notice of community comments
Posted by Lewis John Mcgibbney <le...@gmail.com>.
Hi Enis,
No I'm not using Git, but realise that a few of you were/are,
therefore I am more than happy for you to revert the changes I made to
suit those Git repos users.
If there is anything else I can do then please say and I will help to
make the necessary changes.
Thanks
On Mon, Dec 12, 2011 at 10:56 PM, Enis Söztutar <en...@gmail.com> wrote:
> Hi,
>
> I think we should keep the .gitignore files, and revert the commit for
> this. The git/svn flame wars is still very hot in members@, but even if we
> will not have read/write git access, we will always have at least read-only
> git access at git.apache.org. Some people (like me) prefer to use git as
> their main tool, and we have a git repo at
> git://git.apache.org/gora.gitthat we should support. Besides, the
> release CAN and SHOULD include the
> .gitignore files for git to work correctly.
>
> Normally, we do not need more than the top level .gitignore, but since for
> the build to work with ant, we needed those empty dirs at
> (gora-xxx/lib-ext, etc), and since git does not track empty dirs, the
> default way to add them to repo is to add an empty .gitignore. Now that we
> have switched to maven, we probably do not need some of those dirs, so I
> propose to revert the commit, and selectively do remove the ones not
> needed. One more reason to revert the change is that the patch for issue
> GORA-63 seems to be accidentally committed at
> gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java.
>
> Lewis, are you using the git repo. If not, I can do the changes if you
> prefer.
>
> Thanks,
> Enis
>
> On Sun, Dec 11, 2011 at 1:01 PM, Lewis John Mcgibbney <
> lewis.mcgibbney@gmail.com> wrote:
>
>> Hi,
>>
>> You should be able to see this has now been addressed and Committed @
>> revision 1213062 in trunk.
>>
>> Thanks
>>
>> Lewis
>>
>> On Thu, Dec 8, 2011 at 10:16 PM, Lewis John Mcgibbney
>> <le...@gmail.com> wrote:
>> > OK please see below
>> >>
>> >>
>> >> Yeah we can remove the .gitnore files, feel free to svn remove them, +1.
>> >
>> > will do
>> >
>> >>
>> >>
>> >> I'd like to move away from having any of these files in trunk since we
>> >> don't
>> >> need them as they are all available on Central right? Let's get rid of
>> >> them...
>> >
>> > Yeah, we've moved completely away from the cassandra and hector versions
>> and
>> > now support 1.X, in addition this thrift jar looks pretty our of place as
>> > I've upgraded the HBase dependency to 0.90.4 (latest stable as well).
>> >
>> > I'll look into it and get a Jira logged and patch submitted.
>> >
>> > ta
>> >
>> >>
>> >>
>> >> Cheers,
>> >> Chris
>> >>
>> > Thanks
>> > Lewis
>> >
>> >
>> > --
>> > Lewis
>> >
>>
>>
>>
>> --
>> Lewis
>>
--
Lewis
Re: Taking notice of community comments
Posted by Enis Söztutar <en...@gmail.com>.
Hi,
I think we should keep the .gitignore files, and revert the commit for
this. The git/svn flame wars is still very hot in members@, but even if we
will not have read/write git access, we will always have at least read-only
git access at git.apache.org. Some people (like me) prefer to use git as
their main tool, and we have a git repo at
git://git.apache.org/gora.gitthat we should support. Besides, the
release CAN and SHOULD include the
.gitignore files for git to work correctly.
Normally, we do not need more than the top level .gitignore, but since for
the build to work with ant, we needed those empty dirs at
(gora-xxx/lib-ext, etc), and since git does not track empty dirs, the
default way to add them to repo is to add an empty .gitignore. Now that we
have switched to maven, we probably do not need some of those dirs, so I
propose to revert the commit, and selectively do remove the ones not
needed. One more reason to revert the change is that the patch for issue
GORA-63 seems to be accidentally committed at
gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java.
Lewis, are you using the git repo. If not, I can do the changes if you
prefer.
Thanks,
Enis
On Sun, Dec 11, 2011 at 1:01 PM, Lewis John Mcgibbney <
lewis.mcgibbney@gmail.com> wrote:
> Hi,
>
> You should be able to see this has now been addressed and Committed @
> revision 1213062 in trunk.
>
> Thanks
>
> Lewis
>
> On Thu, Dec 8, 2011 at 10:16 PM, Lewis John Mcgibbney
> <le...@gmail.com> wrote:
> > OK please see below
> >>
> >>
> >> Yeah we can remove the .gitnore files, feel free to svn remove them, +1.
> >
> > will do
> >
> >>
> >>
> >> I'd like to move away from having any of these files in trunk since we
> >> don't
> >> need them as they are all available on Central right? Let's get rid of
> >> them...
> >
> > Yeah, we've moved completely away from the cassandra and hector versions
> and
> > now support 1.X, in addition this thrift jar looks pretty our of place as
> > I've upgraded the HBase dependency to 0.90.4 (latest stable as well).
> >
> > I'll look into it and get a Jira logged and patch submitted.
> >
> > ta
> >
> >>
> >>
> >> Cheers,
> >> Chris
> >>
> > Thanks
> > Lewis
> >
> >
> > --
> > Lewis
> >
>
>
>
> --
> Lewis
>
Re: Taking notice of community comments
Posted by Lewis John Mcgibbney <le...@gmail.com>.
Hi,
You should be able to see this has now been addressed and Committed @
revision 1213062 in trunk.
Thanks
Lewis
On Thu, Dec 8, 2011 at 10:16 PM, Lewis John Mcgibbney
<le...@gmail.com> wrote:
> OK please see below
>>
>>
>> Yeah we can remove the .gitnore files, feel free to svn remove them, +1.
>
> will do
>
>>
>>
>> I'd like to move away from having any of these files in trunk since we
>> don't
>> need them as they are all available on Central right? Let's get rid of
>> them...
>
> Yeah, we've moved completely away from the cassandra and hector versions and
> now support 1.X, in addition this thrift jar looks pretty our of place as
> I've upgraded the HBase dependency to 0.90.4 (latest stable as well).
>
> I'll look into it and get a Jira logged and patch submitted.
>
> ta
>
>>
>>
>> Cheers,
>> Chris
>>
> Thanks
> Lewis
>
>
> --
> Lewis
>
--
Lewis
Re: Taking notice of community comments
Posted by Lewis John Mcgibbney <le...@gmail.com>.
OK please see below
>
> Yeah we can remove the .gitnore files, feel free to svn remove them, +1.
>
will do
>
> I'd like to move away from having any of these files in trunk since we
> don't
> need them as they are all available on Central right? Let's get rid of
> them...
>
Yeah, we've moved completely away from the cassandra and hector versions
and now support 1.X, in addition this thrift jar looks pretty our of place
as I've upgraded the HBase dependency to 0.90.4 (latest stable as well).
I'll look into it and get a Jira logged and patch submitted.
ta
>
> Cheers,
> Chris
>
> Thanks
Lewis
--
*Lewis*
Re: Taking notice of community comments
Posted by "Mattmann, Chris A (388J)" <ch...@jpl.nasa.gov>.
Hey Lewis,
On Dec 8, 2011, at 1:36 PM, Lewis John Mcgibbney wrote:
> Hi Guys,
>
> If you take a look at this thread here [1], Sebb and others kindly offered
> various opinions prior to the 0.1-incubating release. In summary these were
> with regards to the following
> 1) The source distribution (or any )should not include all the .gitignore
> files, I'm aware that Gora was originally (solely) hosted on GitHub but not
> anymore so is it possible to remove these?
Yeah we can remove the .gitnore files, feel free to svn remove them, +1.
> 2) The fact that we are still shipping with several jars in SVN, when we
> come round to pushing a release these will also be in the source archive.
> The offending ones are
> - cassandra-all-0.8.0.jar
> - hector-core-0.8.0-1.jar
> - thrift-0.2.0.jar
> - ivy-2.1.0.jar
> Can these be removed? I am firmly for the vote to remove the ones in
> gora-cassandra module as we now suppport Cassandra 1.X, what about
> gora-hbase? As the Ivy stuff is not being maintained does anyone have a
> preference on this?
I'd like to move away from having any of these files in trunk since we don't
need them as they are all available on Central right? Let's get rid of them...
Cheers,
Chris
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++