[GitHub] [helix] alirezazamani opened a new pull request #624: Stabilize 5 unstable tests

[GitBox <gi...@apache.org>]

alirezazamani opened a new pull request #624: Stabilize 5 unstable tests
URL: https://github.com/apache/helix/pull/624
 
 
   ### Issues
   - [x] My PR addresses the following Helix issues and references them in the PR title:
   Fixes #619 , #620 , #621 , #622 , #623 .
   
   ### Description
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   In this commit three test that were unstable for some time has been stabilized.
   1- TestWorkflowControllerDataProvider:
   This test were rely on thread sleep. This has been changed to TestHelper.verify.
   2-TestDrop:
   This test were rely on thread sleep. This has been changed to TestHelper.verify.
   3-TestGetLastScheduledTaskExecInfo:
   This test were rely on thread sleep. This has been changed to TestHelper.verify.
   Also a check has been added to measure the scheduled tasks and compared the
   result with the expected number of tasks that should be scheduled.
   Also in this test some of the hard coded strings for queue naming
   has been removed and replaced with TestHelper.getTestMethodName().
   4- TestStopWorkflow:
   At the beginning of each test, participant have started and at the end of the
   test, participants have stopped. Hence dependency between the tests added to
   avoid potential conflicts between individual tests. Also one global variable
   has been use among the task to stop which has been changed to local variable.
   Also Thread.sleep has been eliminated.
   5- TestClusterVerifier:
   This test were rely on thread sleep. This has been changed to TestHelper.verify.
   
   ### Tests
   
   - [x] The following is the result of the "mvn test" command on the appropriate module:
   
   Test Result 1: mvn test
   [INFO] Tests run: 886, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,286.007 s - in TestSuite
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 886, Failures: 0, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  54:51 min
   [INFO] Finished at: 2019-11-20T10:10:53-08:00
   [INFO] ------------------------------------------------------------------------
   
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org