You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/09/07 02:05:33 UTC
[I] Add regression coverage for blank navigation search queries [rocketmq-dashboard]
btlqql opened a new issue, #4014:
URL: https://github.com/apache/rocketmq-dashboard/issues/4014
## Problem
The current test suite does not cover blank navigation search queries.
## Expected behavior
- A focused Vitest case locks the existing behavior.
- The targeted test file passes and fails if the covered behavior regresses.
## Scope
Only add regression coverage for $(@{Slug=navigation-search-blank; Focus=blank navigation search queries; PrTitle=test(navigation): cover blank navigation search queries; TestFile=web/src/layouts/navigationSearch.test.ts; Mode=existing; Append=describe('navigation search blank queries', () => {
it('returns entries unchanged for empty and whitespace-only queries', () => {
const entries = [{ key: '/cluster', label: 'RocketMQ 集群' }];
expect(filterNavigationEntries(entries, '')).toEqual(entries);
expect(filterNavigationEntries(entries, ' ')).toEqual(entries);
});
});}.TestFile). No runtime behavior changes.
## Acceptance criteria
- [ ] The targeted Vitest file passes.
- [ ] git diff --check is clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for blank navigation search queries [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #4014: Add regression coverage for blank navigation search queries
URL: https://github.com/apache/rocketmq-dashboard/issues/4014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for blank navigation search queries [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #4014:
URL: https://github.com/apache/rocketmq-dashboard/issues/4014#issuecomment-5581032252
Closing this issue. Two PRs attempted the coverage it asks for, and neither could be merged.
- #4015 (btlqql) - withdrawn unmerged by its own author on 2026-09-07.
- #4063 (Yanghanrui666) - closed today as a verbatim duplicate of #4015: same target test file, same added lines byte for byte, and it claimed `Closes #4014` despite this issue having been filed by a different contributor.
The reason we are closing the issue rather than asking for a third attempt is that the coverage requested here would not add value:
The submitted test is mutation-insensitive. Delete the guard it claims to cover in `filterNavigationEntries` and the test still passes, because the full-list return for an empty or whitespace-only query is also what the surrounding code produces without the guard. It buys a coverage line, not a behaviour guarantee. A useful test here would assert something that breaks when the guard is removed.
To be clear about scope: this is a judgement about these six specific assertions, not a stance against frontend tests. Substantive frontend tests are merged here regularly.
The actual testing gap in this repository is a different one, and it is still open and unclaimed: the `Frontend Build (Node 20)` job in `.github/workflows/ci.yml` runs `npm ci` followed by `npm run build` and never runs `vitest`, so none of the roughly 936 existing frontend tests gate anything. Two of them are already flaky (`AlertsPage > disables other alert rule mutations while a bulk action is running` and `TopicPage > keeps the selected instance when rebuilding...`), and `ci.yml` itself currently fails at startup so no checks are reported on any PR at all. A PR that stabilises those two and wires `npm run test` into the frontend job would do more for this codebase than any of the six test files requested by this batch of issues.
If you believe a specific assertion here does have value, please open a new issue that names the uncovered branch with observable behaviour and shows that the test fails when the guarded code is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for blank navigation search queries [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4014:
URL: https://github.com/apache/rocketmq-dashboard/issues/4014#issuecomment-5573261239
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
**Feasibility:** Feasible
**Scope:** Test-only regression coverage for blank navigation search queries — no runtime behavior changes
**Compatibility:** No breaking changes
Well-scoped test addition following the established pattern. Good candidate for a contributor PR.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org