You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/03 09:48:43 UTC

[GitHub] [shardingsphere] TeslaCN opened a new issue #13437: Why the equal RouteMapper is duplicated in one execution context?

TeslaCN opened a new issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437


   https://github.com/apache/shardingsphere/blob/1ea6d35c6a2deacb6e148158c6ac4adc6c60ef38/shardingsphere-infra/shardingsphere-infra-executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/context/ExecutionContextBuilder.java#L73-L78
   
   ![image](https://user-images.githubusercontent.com/20503072/140038642-acffc9de-73b9-4733-b65b-a901c2734c05.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN commented on issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437#issuecomment-961593634


   > The proposal of spilt ExecutionContext and RouteContext is decouple these 2 modules, keep one module has independent context.
   > 
   > I am not sure merge or not, the class ExecutionContext and RouteContext contains same fields, but still contains different fields, it can not reuse the whole class.
   
   Thanks for your answer!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN closed issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
TeslaCN closed issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437#issuecomment-961593133


   The proposal of spilt ExecutionContext and RouteContext is decouple these 2 modules, keep one module has independent context.
   
   I am not sure merge or not, the class ExecutionContext and RouteContext contains same fields, but still contains different fields, it can not reuse the whole class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN closed issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
TeslaCN closed issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN closed issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
TeslaCN closed issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437#issuecomment-961593133


   The proposal of spilt ExecutionContext and RouteContext is decouple these 2 modules, keep one module has independent context.
   
   I am not sure merge or not, the class ExecutionContext and RouteContext contains same fields, but still contains different fields, it can not reuse the whole class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437#issuecomment-961593133


   The proposal of spilt ExecutionContext and RouteContext is decouple these 2 modules, keep one module has independent context.
   
   I am not sure merge or not, the class ExecutionContext and RouteContext contains same fields, but still contains different fields, it can not reuse the whole class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] TeslaCN commented on issue #13437: Why the equal RouteMapper is duplicated in one execution context?

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #13437:
URL: https://github.com/apache/shardingsphere/issues/13437#issuecomment-961593634






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org