You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/28 13:25:01 UTC
[GitHub] [ozone] ChenSammi opened a new pull request, #3908: HDDS-7321. Auto rocksDB small sst files compaction.
ChenSammi opened a new pull request, #3908:
URL: https://github.com/apache/ozone/pull/3908
https://issues.apache.org/jira/browse/HDDS-7332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1010809280
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -358,6 +358,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
Review Comment:
got it!! Thanks sammi!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1008360825
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -358,6 +358,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
Review Comment:
@myskov these config annotations are generated at compile time into XML format (search for `ozone-default-generated.xml` after build). They should not be added manually to `ozone-default.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1422069913
@ChenSammi Thank you for the contribution.
@myskov @kerneltime @DaveTeng0 Thank you for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1345817295
@symious , thanks for the review.
> 1. The interface we are using is `check()`, but `compaction` seems more than a check operation since it's updating the rocksdb.
>
> 2. The performance issue might not be annoying, Users or Devs might not be easy to find their cluster slow caused by this operation.
>
>
> I was wondering if we don't do the compaction operation in `check()`, but only add a `need to compact` tag. Meanwhile, we can have a compaction thread doing the real compaction when Datanode is not busy so that the Datanode won't be affected by the compaction.
Rocksdb has implemented somehow the way you suggested. rocksdb.compactRange will return immediately. The real compaction will happen in another background thread per RocksDB's schedule.
About the performance concern, I have did some calculation about the rocksdb size of single volume. Say volume is 16TB, in small object/file situation, say 1MB each file, there will be 16 million files(one block each file). Currently, one block with one chunk is 63 byte(protobuf serialized), it's totally about 1GB for all block data. Consider there is other data in rocksdb, the total size of rocksdb per 16TB volume could be no more than several GB, or less than 1GB if the files are big files. So I'm not very worry about the rocksdb performance on datanode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1415483667
Thanks @symious @kerneltime for the code review. All the comments are addressed. Please help to take another look of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1408073914
I found there is a new value for this option: "ManagedCompactRangeOptions.BottommostLevelCompaction" which is "kForceOptimized", the comment for this value is as follows.
```
// Always compact bottommost level but in bottommost level avoid
// double-compacting files created in the same compaction
```
I'm not sure if this new value is brought up because of some performance issue, may be we can also make this configurable for the convenience of future upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1090229268
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -364,6 +364,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
+ defaultValue = "true",
+ type = ConfigType.BOOLEAN,
+ tags = { DATANODE },
+ description = "Auto compaction small sst files when condition is met. "
Review Comment:
```suggestion
description = "Auto compact small SST files (rocksdb.auto-compaction-small-sst-file-size-threshold) when count exceeds (rocksdb.auto-compaction-small-sst-file-num-threshold)"
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -364,6 +364,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
+ defaultValue = "true",
+ type = ConfigType.BOOLEAN,
+ tags = { DATANODE },
+ description = "Auto compaction small sst files when condition is met. "
+ )
+ private boolean autoCompactionSmallSstFile = true;
+
+ @Config(key = "rocksdb.auto-compaction-small-sst-file-size-threshold",
+ defaultValue = "1MB",
+ type = ConfigType.SIZE,
+ tags = { DATANODE },
+ description = "Sst files with size smaller than threshold is a target."
+ )
+ private long autoCompactionSmallSstFileSize = 1024 * 1024;
+
+ @Config(key = "rocksdb.auto-compaction-small-sst-file-num-threshold",
+ defaultValue = "512",
+ type = ConfigType.INT,
+ tags = { DATANODE },
+ description = "Auto compaction will happen if the number of small Sst " +
+ " files exceeds this threshold."
Review Comment:
```suggestion
description = "Auto compaction will happen if the number of small SST " +
" files exceeds this threshold."
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -364,6 +364,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
+ defaultValue = "true",
+ type = ConfigType.BOOLEAN,
+ tags = { DATANODE },
+ description = "Auto compaction small sst files when condition is met. "
+ )
+ private boolean autoCompactionSmallSstFile = true;
+
+ @Config(key = "rocksdb.auto-compaction-small-sst-file-size-threshold",
+ defaultValue = "1MB",
+ type = ConfigType.SIZE,
+ tags = { DATANODE },
+ description = "Sst files with size smaller than threshold is a target."
Review Comment:
```suggestion
description = "SST files smaller than this configuration will be auto compacted."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
symious commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1345292799
@ChenSammi Thank you for the work. I think it's a very good feature to have.
Two things come to my mind:
1. The interface we are using is `check()`, but `compaction` seems more than a check operation since it's updating the rocksdb.
2. The performance issue might not be annoying, Users or Devs might not be easy to find their cluster slow caused by this operation.
I was wondering if we don't do the compaction operation in `check()`, but only add a `need to compact` tag. Meanwhile, we can have a compaction thread doing the real compaction when Datanode is not busy so that the Datanode won't be affected by the compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1009969613
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -358,6 +358,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
Review Comment:
hmm just for myself learning~ when do we usually add configuration parameters into file _ozone-default.xml_, and when to add to the _Datanodeconfiguration_ class~?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1413696882
> ManagedCompactRangeOptions
Hi @symious , Cannot find this kForceOptimized in the latest RocksDB release 7.9.2. Can you share the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1010059856
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -358,6 +358,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
Review Comment:
Per my understanding, annotation style configuration is preferred over ozone-default.xml currently. @DaveTeng0 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1415465648
> let's choose a good default value instead as current.
Ok, it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious merged pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious merged PR #3908:
URL: https://github.com/apache/ozone/pull/3908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on a diff in pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
myskov commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1008324718
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -358,6 +358,31 @@ public void setWaitOnAllFollowers(boolean val) {
)
private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
+ @Config(key = "rocksdb.auto-compaction-small-sst-file",
Review Comment:
looks like these props should be described in ozone-default.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "DaveTeng0 (via GitHub)" <gi...@apache.org>.
DaveTeng0 commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1408020699
hello guys~ looks like sammi has addressed all questions. Should we merge this if no further comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1422070963
Thanks @symious @myskov @kerneltime @DaveTeng0 for the code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1295703157
> BTW, the [HDDS-7332](https://issues.apache.org/jira/browse/HDDS-7332) doesn't say anything about rocksdb compaction
Right, It's HDDS-7331 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] myskov commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by GitBox <gi...@apache.org>.
myskov commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1295307545
BTW, the [HDDS-7332](https://issues.apache.org/jira/browse/HDDS-7332) doesn't say anything about rocksdb compaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1414835042
> > Cannot find this kForceOptimized in the latest RocksDB release 7.9.2. Can you share the link?
>
> The option is in https://github.com/facebook/rocksdb/blob/main/include/rocksdb/options.h#L1844, seems not added to jni yet, since it's added in 2019, not sure why it's not included in jni.
>
> I raised a PR there, [facebook/rocksdb#11181](https://github.com/facebook/rocksdb/pull/11181), hoping someone can make some comments.
>
> Anyway, I think it will be good to have the option configurable, maybe in the future, there could be some new choice on the options.
@symious , thanks for the further info. Configuration properties are for customers to do the tuning by themselves. As most customers don't need to know or have the knowledge of these low level specific rocksdb properties meaning and impact, let's choose a good default value instead as current.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #3908:
URL: https://github.com/apache/ozone/pull/3908#issuecomment-1414713278
> Cannot find this kForceOptimized in the latest RocksDB release 7.9.2. Can you share the link?
The option is in https://github.com/facebook/rocksdb/blob/main/include/rocksdb/options.h#L1844, seems not added to jni yet, since it's added in 2019, not sure why it's not included in jni.
I raised a PR there, https://github.com/facebook/rocksdb/pull/11181, hoping someone can make some comments.
Anyway, I think it will be good to have the option configurable, maybe in the future, there could be some new choice on the options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org