[jira] [Commented] (DBCP-319) Make private fields final where possible

["Alberto Mozzone (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DBCP-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027573#comment-13027573 ] 

Alberto Mozzone commented on DBCP-319:
--------------------------------------

If the problem is to make private fields "final", I'd let Eclipse do that: it's just a matter of configuring the "Save actions". HTH.

> Make private fields final where possible
> ----------------------------------------
>
>                 Key: DBCP-319
>                 URL: https://issues.apache.org/jira/browse/DBCP-319
>             Project: Commons Dbcp
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 1.3.1, 1.4.1
>
>         Attachments: DBCP-319-private-final.patch
>
>
> Several private fields could be made final:
> AbandonedTrace.config
> AbandonedTrace.AbandonedObjectException._createdTime
> cpdsadapter.PooledConnectionImpl:
> * connection
> * delegatingConnection
> * eventListeners
> * statementEventListeners
> * pstmtPool is protected, but could probably be made final if it were not for the API change that would imply
> cpdsadapter.PooledConnectionImpl.PStmtKey (nested class, variables are protected, but might as well be private)
> * all of its fields could be made final
> datasources.[Keyed]CPDSConnectionFactory.validatingMap
> datasources.[Keyed]CPDSConnectionFactory.pcMap
> managed.PoolableManagedConnection.transactionRegistry
> managed.PoolableManagedConnectionFactory.transactionRegistry
> managed.TransactionRegistry.transactionManager|caches|xaResources
> .AbandonedObjectPool.config|trace

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira