[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5168: Extend test coverage of gRPC extension

["jamesnetherton (via GitHub)" <gi...@apache.org>]

jamesnetherton commented on code in PR #5168:
URL: https://github.com/apache/camel-quarkus/pull/5168#discussion_r1291315993


##########
docs/modules/ROOT/pages/reference/extensions/grpc.adoc:
##########
@@ -72,3 +118,34 @@ To avoid compilation issues, the `grpc-java` project recommendation is to add a
 
 Alternatively, you can use Maven or Gradle plugins to iterate over the generated code (found at `target/generated-sources` for Maven) and replace all instances of `@javax.annotation.Generated` with `@jakarta.annotation.Generated`.
 
+[id="extensions-grpc-usage-accessing-classpath-resources-in-native-mode"]
+=== Accessing classpath resources in native mode
+
+The gRPC component has various options where resources are resolved from the classpath:
+
+* `keyCertChainResource`
+* `keyResource`
+* `serviceAccountResource`
+* `trustCertCollectionResource`
+
+When using these options in native mode, you must ensure that any such resources are included in the native image.
+
+This can be accomplished by adding the configuration property `quarkus.native.resources.includes` to `application.properties`.

Review Comment:
   I figured it was better to have some instructions inline, because it's nicer to be able to directly copy a code snippet, rather than click away to another page and loose the context of the thing you're interested in (gRPC).
   
   If you think not having it is better, then I can change it. Although, there are other extensions where the docs are like this, so please open an issue so we clean up the rest of the codebase.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org