[jira] [Work logged] (HIVE-25012) Parsing table alias is failing if query has table properties specified

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25012?focusedWorklogId=582166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582166 ]

ASF GitHub Bot logged work on HIVE-25012:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Apr/21 03:00
            Start Date: 14/Apr/21 03:00
    Worklog Time Spent: 10m 
      Work Description: kasakrisz opened a new pull request #2177:
URL: https://github.com/apache/hive/pull/2177


   ### What changes were proposed in this pull request?
   Move `getSimpleTableNameBase` and `findTabRefIdxs` to allow using them from `BaseSemanticAnalyzer.getTableAlias `
   
   ### Why are the changes needed?
   See jira.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   ```
   mvn test -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=fetch_deleted_rows.q -pl itests/qtest -Pitests
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 582166)
    Remaining Estimate: 0h
            Time Spent: 10m

> Parsing table alias is failing if query has table properties specified
> ----------------------------------------------------------------------
>
>                 Key: HIVE-25012
>                 URL: https://issues.apache.org/jira/browse/HIVE-25012
>             Project: Hive
>          Issue Type: Bug
>          Components: CBO, Parser
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code}
> select t1.ROW__IS__DELETED, t1.*, t2.ROW__IS__DELETED, t2.* from t1('acid.fetch.deleted.rows'='true')
> join t2('acid.fetch.deleted.rows'='true') on t1.a = t2.a;
> {code}
> When creating Join RelNode the aliases are used to lookup left and right input RelNodes. Aliases are extracted from the AST subtree of the left and right inputs of the join AST node. In case of a table reference:
> {code}
> TOK_TABREF
>    TOK_TABNAME
>       t1
>    TOK_TABLEPROPERTIES
>       TOK_TABLEPROPLIST
>          TOK_TABLEPROPERTY
>             'acid.fetch.deleted.rows'
>             'true'
> {code} 
> Prior HIVE-24854 queries mentioned above failed because existing solution was not expect TOK_TABLEPROPERTIES.
> The goal of this patch is to parse TOK_TABREF properly using existing solution also used in SemanticAnalyser.doPhase1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)