You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/08/01 11:48:45 UTC
[GitHub] flink pull request #4451: [hotfix][tests] increase timeout in ExecutionGraph...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4451
[hotfix][tests] increase timeout in ExecutionGraphRestartTest
## What is the purpose of the change
On rare occasions, TravisCI hit the default timeout waiting for job status changes in `ExecutionGraphRestartTest` (depending on which test was run in parallel). Timeouts should be increased to pass tests.
## Brief change log
- re-factor the hard-coded timeouts to constants in `ExecutionGraphRestartTest`
- increase the timeouts for job status changes (the deployment timeout is per job vertex and may still be fine as it is)
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink hotfix_eg_tests_timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4451
----
commit 0620a500ec875b4a8806572342ec1154d441f657
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-08-01T11:44:54Z
[hotfix][tests] increase timeout in ExecutionGraphRestartTest
On rare occasions, TravisCI hit the default timeout (depending on which test
was run in parallel). Increase the timeouts to make sure this passes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4451: [hotfix][tests] increase timeout in ExecutionGraphRestart...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4451
Please see https://issues.apache.org/jira/browse/FLINK-7352 and it seems you are right - increased timeouts do not solve this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4451: [hotfix][tests] increase timeout in ExecutionGraphRestart...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4451
Is this really the root of the problem, or is this maybe affected by this:
https://github.com/apache/flink/blob/master/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java#L203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4451: [hotfix][tests] increase timeout in ExecutionGraph...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK closed the pull request at:
https://github.com/apache/flink/pull/4451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4451: [hotfix][tests] increase timeout in ExecutionGraphRestart...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4451
good question - but I encounter this test failure in 1.3.2 RC2, too - let me create a JIRA for this nonetheless to investigate further
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---