[GitHub] [cassandra] pauloricardomg commented on a change in pull request #780: Cannot replace_address /X because it doesn't exist in gossip

[GitBox <gi...@apache.org>]

pauloricardomg commented on a change in pull request #780:
URL: https://github.com/apache/cassandra/pull/780#discussion_r542895402



##########
File path: src/java/org/apache/cassandra/gms/EndpointState.java
##########
@@ -138,6 +143,12 @@ void markDead()
         isAlive = false;
     }
 
+    public boolean isEmpty()

Review comment:
       I have a slight preference to renaming this to `isEmptyWithoutStatus` or better name to prevent potential misuse, the state may still contain other non-status fields.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org