You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/10 10:38:00 UTC
[jira] [Work logged] (BEAM-4622) Many Beam SQL expressions never
have their validation called
[ https://issues.apache.org/jira/browse/BEAM-4622?focusedWorklogId=121343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121343 ]
ASF GitHub Bot logged work on BEAM-4622:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/18 10:37
Start Date: 10/Jul/18 10:37
Worklog Time Spent: 10m
Work Description: aromanenko-dev opened a new pull request #5912: [BEAM-4622] Makes required to call Beam SQL expressions validation
URL: https://github.com/apache/beam/pull/5912
Moved huge switch statement block into separate method which returns new object of `BeamSqlExpression` and then that object calls `accept()` method to perform a validation. This refactoring discovered some test failures that were fixed by fixing `accept()` implementation of corresponding expressions.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 121343)
Time Spent: 10m
Remaining Estimate: 0h
> Many Beam SQL expressions never have their validation called
> ------------------------------------------------------------
>
> Key: BEAM-4622
> URL: https://issues.apache.org/jira/browse/BEAM-4622
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Alexey Romanenko
> Priority: Major
> Labels: easyfix, newbie, starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In {{BeamSqlFnExecutor}} there is a pattern where first the returned expression is assigned to a variable {{ret}} and then after a giant switch statement the validation is invoked. But there are many code paths that just call {{return}} and skip validation. This should be refactored so it is impossible to short-circuit on accident like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)