[GitHub] [spark] zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support

[GitBox <gi...@apache.org>]

zhengruifeng commented on issue #26972: [SPARK-30321][Ml] Log weightSum in Algo that has weights support
URL: https://github.com/apache/spark/pull/26972#issuecomment-568610797
 
 
   I notice that other statistics for tree models are logged in `RandomForest.run`:
   ```scala
       instr match {
         case Some(instrumentation) =>
           instrumentation.logNumFeatures(metadata.numFeatures)
           instrumentation.logNumClasses(metadata.numClasses)
           instrumentation.logNumExamples(metadata.numExamples)
         case None =>
           logInfo("numFeatures: " + metadata.numFeatures)
           logInfo("numClasses: " + metadata.numClasses)
           logInfo("numExamples: " + metadata.numExamples)
       }
   ```
   
   Can we just log `weightSum` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org