You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by James Peach <jp...@apache.org> on 2013/12/08 04:48:07 UTC

Re: git commit: TS-312: Add option to always share keep-alive connections to the origin server

On Dec 6, 2013, at 5:05 PM, bcall@apache.org wrote:

> Updated Branches:
>  refs/heads/master 960c3f8f4 -> d6ab74824
> 
> 
> TS-312: Add option to always share keep-alive connections to the origin server
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/d6ab7482
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/d6ab7482
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/d6ab7482
> 
> Branch: refs/heads/master
> Commit: d6ab7482489be6b79d911f55564afb707c7004d6
> Parents: 960c3f8
> Author: Bryan Call <bc...@apache.org>
> Authored: Fri Dec 6 17:04:50 2013 -0800
> Committer: Bryan Call <bc...@apache.org>
> Committed: Fri Dec 6 17:04:50 2013 -0800
> 
> ----------------------------------------------------------------------
> CHANGES                  |  2 ++
> mgmt/RecordsConfig.cc    |  2 ++
> proxy/http/HttpConfig.cc |  1 +
> proxy/http/HttpConfig.h  |  1 +
> proxy/http/HttpSM.cc     | 16 +++++++---------
> 5 files changed, 13 insertions(+), 9 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d6ab7482/CHANGES
> ----------------------------------------------------------------------
> diff --git a/CHANGES b/CHANGES
> index cacc5ad..eca1bad 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -1,6 +1,8 @@
>                                                          -*- coding: utf-8 -*-
> Changes with Apache Traffic Server 4.2.0
> 
> +  *) [TS-312] Add option to always share keep-alive connections to the origin server
> +
>   *) [TS-2419] Don't close client connection when responding with a 204 and there is no body
> 
>   *) [TS-1146] Add RFC 5077 TLS session ticket support.
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d6ab7482/mgmt/RecordsConfig.cc
> ----------------------------------------------------------------------
> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
> index a54e018..bf3674e 100644
> --- a/mgmt/RecordsConfig.cc
> +++ b/mgmt/RecordsConfig.cc
> @@ -456,6 +456,8 @@ RecordElement RecordsConfig[] = {
>   ,
>   {RECT_CONFIG, "proxy.config.http.origin_min_keep_alive_connections", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>   ,
> +  {RECT_CONFIG, "proxy.config.http.attach_sever_session_to_client", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
> +  ,

Sever session?


Re: git commit: TS-312: Add option to always share keep-alive connections to the origin server

Posted by Leif Hedstrom <zw...@apache.org>.
On Dec 7, 2013, at 7:48 PM, James Peach <jp...@apache.org> wrote:

> On Dec 6, 2013, at 5:05 PM, bcall@apache.org wrote:
> 
>> Updated Branches:
>> +++ b/CHANGES
>> @@ -1,6 +1,8 @@
>>                                                         -*- coding: utf-8 -*-
>> Changes with Apache Traffic Server 4.2.0
>> 
>> +  *) [TS-312] Add option to always share keep-alive connections to the origin server
>> +
>>  *) [TS-2419] Don't close client connection when responding with a 204 and there is no body
>> 
>>  *) [TS-1146] Add RFC 5077 TLS session ticket support.
>> 
>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d6ab7482/mgmt/RecordsConfig.cc
>> ----------------------------------------------------------------------
>> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
>> index a54e018..bf3674e 100644
>> --- a/mgmt/RecordsConfig.cc
>> +++ b/mgmt/RecordsConfig.cc
>> @@ -456,6 +456,8 @@ RecordElement RecordsConfig[] = {
>>  ,
>>  {RECT_CONFIG, "proxy.config.http.origin_min_keep_alive_connections", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>>  ,
>> +  {RECT_CONFIG, "proxy.config.http.attach_sever_session_to_client", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
>> +  ,
> 
> Sever session?



Also, shouldn’t this be default to “1” to be backwards compatible ?

— leif


Re: git commit: TS-312: Add option to always share keep-alive connections to the origin server

Posted by Leif Hedstrom <zw...@apache.org>.
On Dec 7, 2013, at 7:48 PM, James Peach <jp...@apache.org> wrote:

> On Dec 6, 2013, at 5:05 PM, bcall@apache.org wrote:
> 
>> Updated Branches:
>> +++ b/CHANGES
>> @@ -1,6 +1,8 @@
>>                                                         -*- coding: utf-8 -*-
>> Changes with Apache Traffic Server 4.2.0
>> 
>> +  *) [TS-312] Add option to always share keep-alive connections to the origin server
>> +
>>  *) [TS-2419] Don't close client connection when responding with a 204 and there is no body
>> 
>>  *) [TS-1146] Add RFC 5077 TLS session ticket support.
>> 
>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d6ab7482/mgmt/RecordsConfig.cc
>> ----------------------------------------------------------------------
>> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
>> index a54e018..bf3674e 100644
>> --- a/mgmt/RecordsConfig.cc
>> +++ b/mgmt/RecordsConfig.cc
>> @@ -456,6 +456,8 @@ RecordElement RecordsConfig[] = {
>>  ,
>>  {RECT_CONFIG, "proxy.config.http.origin_min_keep_alive_connections", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
>>  ,
>> +  {RECT_CONFIG, "proxy.config.http.attach_sever_session_to_client", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
>> +  ,
> 
> Sever session?



Also, shouldn’t this be default to “1” to be backwards compatible ?

— leif