[GitHub] [incubator-superset] john-bodley commented on issue #7032: Fetch charts with GET to benefit from browser cache and conditional requests

[GitBox <gi...@apache.org>]

john-bodley commented on issue #7032: Fetch charts with GET to benefit from browser cache and conditional requests
URL: https://github.com/apache/incubator-superset/pull/7032#issuecomment-473083255
 
 
   @betodealmeida just to clarify step 4 (and per your diagram) you have: 
   
   - **Before**: Superset caches the dataframe.
   - **After**: Superset serializes the dataframe and caches the **HTTP response**.
   
   yet in the code it still seems like we're caching the result set from the database and thus I wonder if the diagram and thus **After** phase should mention that there's an additional entry in the server cache, i.e., after step (4) the server-side cache would contain:
   - The cached result set (as a dataframe).
   - The cached `superset/explore_json` HTTP response which includes server-side Python visualization specific mutations.
   
   Note I'm not saying this is wrong as I strongly believe that the database response should be cache given that represents the bulk of the compute, I just wanted to get clarity on the logic.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org